From: Martin Peres <martin.peres@linux.intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>,
Petri Latvala <petri.latvala@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v2] runner: Add explicit "notrun" results for tests that were not executed
Date: Thu, 20 Dec 2018 14:04:39 +0200 [thread overview]
Message-ID: <963f1a1f-71e7-b428-1bdd-9b1751324ecb@linux.intel.com> (raw)
In-Reply-To: <20181220120209.45fdrt4u5uw6l5br@ahiler-desk1.fi.intel.com>
On 20/12/2018 14:02, Arkadiusz Hiler wrote:
> On Mon, Dec 17, 2018 at 03:07:40PM +0200, Petri Latvala wrote:
>> When possible, all tests we know we were going to attempt to execute
>> now appear in the results as "notrun". The only known case where it's
>> not possible to add an explicit "notrun" is when running in
>> multiple-mode, because "no subtests" and "run all subtests, we didn't
>> list them beforehand" are represented the same.
>>
>> Note: A function call is commented out in resultgen.c because it needs
>> the function to exist, and that's in a patch that is still in flight.
>>
>> v2: Rebase and adjust to already landed json changes
>>
>> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
>> Cc: Martin Peres <martin.peres@linux.intel.com>
>> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
>> Acked-by: Martin Peres <martin.peres@linux.intel.com>
> Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
>
And the failure caught in CI is actually from this known bug:
https://bugs.freedesktop.org/show_bug.cgi?id=109119
So, good for pushing!
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-12-20 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 13:07 [igt-dev] [PATCH i-g-t v2] runner: Add explicit "notrun" results for tests that were not executed Petri Latvala
2018-12-17 13:29 ` Petri Latvala
2018-12-17 14:11 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-12-17 15:07 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-12-20 12:02 ` [igt-dev] [PATCH i-g-t v2] " Arkadiusz Hiler
2018-12-20 12:04 ` Martin Peres [this message]
2018-12-20 12:02 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=963f1a1f-71e7-b428-1bdd-9b1751324ecb@linux.intel.com \
--to=martin.peres@linux.intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox