[igt-dev] [PATCH i-g-t 0/7] Fixes from updating igt packaging in Fedora

Lyude
2019-04-16T20:11:21Z

From: Lyude Paul <lyude@redhat.com>

For work reasons, I've been tasked with getting Fedora running portions
of IGT in our own CI infrastructure. In doing so I needed to get our RPM
packaging up to date, building and passing the meson unit tests on
Fedora 29 and Fedora Rawhide. This ended up exposing some rather
interesting bugs, and also prompted me to update the Dockerfile and
Gitlab CI settings that we use for testing builds. So, here's my fixes
and improvements!

As well, a couple of open questions I still have with this series:

* For the first commit, "lib/tests: Fix test failures with meson
0.50.0", is this an appropriate fix or should we just modify the
return codes IGT spits out on test timeouts? (seems we used to have an
error code specifically for timeouts)
* For "lib: Stop using assert() for runtime checks", there's still a
bunch of other places in igt that I spotted using assert() - should we
also completely replace those with igt_internal_assert()?

Lyude Paul (7):
lib/tests: Fix test failures with meson 0.50.0
meson: Don't redefine gettid if the C library provides it
lib: Stop using assert() for runtime checks
lib/igt_core: Just use igt_can_fail() in __igt_run_subtest()
Use pkgconfig() macros with dnf in Fedora Dockerfile
Update Dockerfile.fedora to Fedora 29
Gitlab CI: Do builds with -Db_ndebug=true

.gitlab-ci.yml | 1 +
Dockerfile.fedora | 50 +++++++++++------------
lib/igt_aux.h | 3 ++
lib/igt_core.c | 22 +++++-----
lib/igt_core.h | 18 +++++++++
lib/tests/igt_assert.c | 2 +-
lib/tests/igt_can_fail.c | 10 ++---
lib/tests/igt_can_fail_simple.c | 2 +-
lib/tests/igt_exit_handler.c | 18 ++++-----
lib/tests/igt_fork.c | 4 +-
lib/tests/igt_invalid_subtest_name.c | 2 +-
lib/tests/igt_no_exit.c | 2 +-
lib/tests/igt_segfault.c | 2 +-
lib/tests/igt_simulation.c | 60 ++++++++++++++--------------
lib/tests/igt_subtest_group.c | 16 ++++----
lib/tests/igt_tests_common.h | 19 ++++-----
lib/tests/meson.build | 15 +++++++
lib/tests/retcode_99_wrapper.sh | 11 +++++
meson.build | 3 ++
19 files changed, 152 insertions(+), 108 deletions(-)
create mode 100644 lib/tests/retcode_99_wrapper.sh

--
2.20.1