public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ser, Simon" <simon.ser@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: [igt-dev] [PATCH i-g-t] meson: add -Wno-missing-braces
Date: Wed, 20 Mar 2019 08:52:49 +0000	[thread overview]
Message-ID: <973e1099bb84177875aeccb4140ad7958bbc5bbd.camel@intel.com> (raw)

Enabling -Werror=missing-braces results in this error with Clang:

    ../tests/kms_vrr.c:203:20: error: suggest braces around
initialization of subobject [-Werror,-Wmissing-braces]
            drmVBlank vbl = { 0 };
                              ^
                              {}

I don't believe there is any value in keeping this, so let's just
disable it.

Signed-off-by: Simon Ser <simon.ser@intel.com>
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 557400a5..bb100b75 100644
--- a/meson.build
+++ b/meson.build
@@ -38,6 +38,7 @@ cc_args = [
 	'-Wno-type-limits',
 	'-Wno-unused-parameter',
 	'-Wno-unused-result',
+	'-Wno-missing-braces',
 	'-Werror=address',
 	'-Werror=array-bounds',
@@ -45,7 +46,6 @@ cc_args = [
 	'-Werror=init-self',
 	'-Werror=int-to-pointer-cast',
 	'-Werror=main',
-	'-Werror=missing-braces',
 	'-Werror=nonnull',
 	'-Werror=pointer-to-int-cast',
 	'-Werror=return-type',
-- 
2.21.0
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-03-20  8:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20  8:52 Ser, Simon [this message]
2019-03-20  9:38 ` [igt-dev] [PATCH i-g-t] meson: add -Wno-missing-braces Jani Nikula
2019-03-20 10:53   ` Ser, Simon
2019-03-20 12:11     ` Jani Nikula
2019-03-20 12:22       ` Petri Latvala
2019-03-21  7:25         ` Ser, Simon
2019-03-21  7:21       ` Ser, Simon
2019-03-20 13:52     ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=973e1099bb84177875aeccb4140ad7958bbc5bbd.camel@intel.com \
    --to=simon.ser@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox