From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 41B6A10E03B for ; Mon, 14 Aug 2023 10:26:56 +0000 (UTC) Message-ID: <977bfe86-362e-7d44-486d-e84b1dbce168@intel.com> Date: Mon, 14 Aug 2023 15:56:50 +0530 MIME-Version: 1.0 Content-Language: en-US To: Bhanuprakash Modem , igt-dev@lists.freedesktop.org References: <20230811184655.157060-1-bhanuprakash.modem@intel.com> <20230811184655.157060-69-bhanuprakash.modem@intel.com> From: "Sharma, Swati2" In-Reply-To: <20230811184655.157060-69-bhanuprakash.modem@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [i-g-t V6 68/81] tests/kms_rotation_crc: Document each subtest for testplan List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: LGTM Reviewed-by: Swati Sharma On 12-Aug-23 12:16 AM, Bhanuprakash Modem wrote: > Add documentation for all kms tests which is used by IGT testplan > documentation. > > V2: - Add plane to the functionality > > Cc: Swati Sharma > Signed-off-by: Bhanuprakash Modem > --- > tests/kms_rotation_crc.c | 133 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 133 insertions(+) > > diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c > index 5ad04407d..847bf4e71 100644 > --- a/tests/kms_rotation_crc.c > +++ b/tests/kms_rotation_crc.c > @@ -22,6 +22,11 @@ > * > */ > > +/** > + * TEST: kms rotation crc > + * Category: Display > + * Description: Tests different rotations with different planes & formats > + */ > #include "igt.h" > #include "igt_vec.h" > #include > @@ -474,6 +479,100 @@ static bool test_format(data_t *data, > return true; > } > > +/** > + * SUBTEST: %s-rotation-180 > + * Description: Rotation test with 180 degree for %arg[1] planes > + * Driver requirement: any > + * Functionality: plane, rotation > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + * > + * arg[1]: > + * > + * @primary: primary > + * @sprite: sprite > + * @cursor: cursor > + */ > + > +/** > + * SUBTEST: %s-rotation-%d > + * Description: Rotation test with %arg[2] degree for %arg[1] planes of gen9+ > + * Driver requirement: any > + * Functionality: plane, rotation > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + * > + * arg[1]: > + * > + * @primary: primary > + * @sprite: sprite > + * > + * arg[2].values: 90, 270 > + */ > + > +/** > + * SUBTEST: bad-pixel-format > + * Description: Checking unsupported pixel format for gen9+ with 90 degree of rotation > + * Driver requirement: any > + * Functionality: plane, rotation > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + * > + * SUBTEST: bad-tiling > + * Description: Checking unsupported tiling for gen9+ with 90 degree of rotation > + * Driver requirement: any > + * Functionality: plane, rotation, tiling > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + */ > + > +/** > + * SUBTEST: primary-%s-tiled-reflect-x-%d > + * Description: Test for %arg[1] & %arg[2] degree rotation on primary plane > + * Driver requirement: any > + * Functionality: plane, rotation, tiling > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + * > + * arg[1]: > + * > + * @4: 4 tiling > + * @x: x tiling > + * @y: y tiling > + * @yf: yf tiling > + * > + * arg[2].values: 0, 180 > + */ > + > +/** > + * SUBTEST: primary-%s-tiled-reflect-x-%d > + * Description: Test for %arg[1] & %arg[2] degree rotation on primary plane > + * Driver requirement: any > + * Functionality: plane, rotation, tiling > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + * > + * arg[1]: > + * > + * @y: y tiling > + * @yf: yf tiling > + * > + * arg[2].values: 90, 270 > + * > + * SUBTEST: sprite-rotation-90-pos-100-0 > + * Description: Rotation test with 90 degree for a plane of gen9+ with given position > + * Driver requirement: any > + * Functionality: plane, rotation > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + */ > static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_format) > { > igt_display_t *display = &data->display; > @@ -792,6 +891,31 @@ static bool reusecrcfromlastround(planeinfos p[2], int lastroundp1format, > > return true; > } > + > +/** > + * SUBTEST: multiplane-rotation > + * Description: Rotation test on both planes by making them fully visible > + * Driver requirement: any > + * Functionality: plane, rotation > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + * > + * SUBTEST: multiplane-rotation-cropping-%s > + * Description: Rotation test on both planes by cropping left/%arg[1] corner of > + * primary plane and right/%arg[1] corner of sprite plane > + * Driver requirement: any > + * Functionality: plane, rotation > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + * > + * arg[1]: > + * > + * @bottom: bottom > + * @top: top > + */ > + > /* > * Here is pipe parameter which is now used only for first pipe. > * It is left here if this test ever was wanted to be run on > @@ -993,6 +1117,15 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe) > igt_require_f(found, "No valid pipe/output combo found.\n"); > } > > +/** > + * SUBTEST: exhaust-fences > + * Description: This test intends to check for fence leaks exhaustively > + * Driver requirement: i915 > + * Functionality: plane, rotation > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + */ > static void test_plane_rotation_exhaust_fences(data_t *data, > enum pipe pipe, > igt_output_t *output,