Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Fix special handling for Intel CHV
Date: Thu, 1 Jun 2023 12:45:21 +0530	[thread overview]
Message-ID: <97f66f89-1b83-6c55-a3f4-6a5020cc360e@intel.com> (raw)
In-Reply-To: <20230530133109.5735-1-juhapekka.heikkila@gmail.com>

LGTM. Please add "Fixes" with gitlab issue# before merging.

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 30-May-23 7:01 PM, Juha-Pekka Heikkila wrote:
> Match software rendering round to what hardware rendering round did
> on Intel CHV.
> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>   tests/kms_cursor_crc.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
> index 3a353a03..61a0d65e 100644
> --- a/tests/kms_cursor_crc.c
> +++ b/tests/kms_cursor_crc.c
> @@ -253,6 +253,10 @@ static void do_single_test(data_t *data, int x, int y, bool hw_test,
>   			igt_assert_crc_equal(hwcrc, &crc_after);
>   		}
>   	} else {
> +		/* If on broken situation on CHV match what hw round did */
> +		if (chv_cursor_broken(data, x) && cursor_visible(data, x, y))
> +			return;
> +
>   		/* Now render the same in software and collect crc */
>   		swbufidx = (data->primary->drm_plane->fb_id ==
>   			    data->primary_fb[SWCOMPARISONBUFFER1].fb_id) ?

      parent reply	other threads:[~2023-06-01  7:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30 13:31 [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Fix special handling for Intel CHV Juha-Pekka Heikkila
2023-05-30 19:23 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-05-31 19:51 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-06-01  7:15 ` Sharma, Swati2 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97f66f89-1b83-6c55-a3f4-6a5020cc360e@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juhapekka.heikkila@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox