Re: [PATCH i-g-t 00/11] igt pipe vs crtc_index cleanups

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 10 Feb 2026, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Feb 10, 2026 at 05:23:41PM +0200, Jani Nikula wrote:
>> While Ville's been focusing on mass conversions with cocci, here are
>> some specific manual pipe vs. crtc_index cleanups.
>> 
>> 
>> Jani Nikula (11):
>>   lib/igt_kms: rename igt_crtc_t crtc_offset member to crtc_index
>>   lib/igt_kms: rename the rest of crtc_offset to crtc_index
>>   lib/kms: rename struct kmstest_connector_config pipe member to
>>     crtc_index
>>   lib/igt_kms: rename _kmstest_connector_config_find_encoder() pipe
>>     parameter to crtc_index
>>   tests/kms_flip: switch to CRTC index terminology
>>   tests/testdisplay: switch to CRTC index terminology
>>   lib/igt_kms: use for_each_crtc() for iterating CRTCs
>>   lib/igt_kms: rename kmstest_get_vblank() param to crtc_index
>>   lib/igt_kms: remove __get_crtc_mask_for_pipe()
>>   lib/igt_kms: pass crtc to igt_crtc_init()
>>   lib/igt_kms: use for_each_crtc() for cleaning up CRTCs
>
> Apart from the missing 1<< in one patch the rest look reasonable to me:
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Thanks, pushed the lot to master.

BR,
Jani.


>
>> 
>>  lib/igt_kms.c       | 106 ++++++++++++++++++--------------------------
>>  lib/igt_kms.h       |  19 ++++----
>>  tests/kms_flip.c    |  56 +++++++++++------------
>>  tests/testdisplay.c |   6 +--
>>  4 files changed, 80 insertions(+), 107 deletions(-)
>> 
>> -- 
>> 2.47.3

-- 
Jani Nikula, Intel