Re: [igt-dev] [PATCH RFC 2/2] lib/igt_core: print card sysfs node at subtest results

[Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>]

On 9/29/22 12:06, Petri Latvala wrote:
> On Thu, Sep 29, 2022 at 10:21:36AM +0200, Mauro Carvalho Chehab wrote:
>> On Wed, 28 Sep 2022 18:26:50 +0200
>> Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:
>>
>>> Hi Mauro,
>>>
>>> On 2022-09-28 at 12:43:20 +0300, Petri Latvala wrote:
>>>> On Wed, Sep 28, 2022 at 10:58:42AM +0200, Mauro Carvalho Chehab wrote:
>>>>> From: Mauro Carvalho Chehab <mchehab@kernel.org>
>>>>>
>>>>> This helps to identify what GPU failed on multi-GPU tests.
>>>> And completely breaks igt_runner when it tries to parse the result
>>>> logs.
>> Yes. That's btw one of the reasons why I submitted it as a RFC: depending
>> on how CI check IGT logs, it can break the test results there as well.
>>
>> Anyway, this is fixable.
>>
>> The point is, once we have multi-GPU tests, we need to have a way to
>> report what GPU failed.
> Imho it's best printed in __igt_fail_assert to get it close to the
> reason why the test is failing.

Yeah, it makes sense to have it there, but, IMO it should also be at the 
result
output, as we could have a test that it skipped on some GPUs and/or fail on
some GPUs while passing on others.


Regards,
Mauro