From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 34EDF6E393 for ; Thu, 18 Jul 2019 10:57:23 +0000 (UTC) From: "Ser, Simon" Date: Thu, 18 Jul 2019 10:57:20 +0000 Message-ID: <98bbef8de64288888e554de33526e0e7367fbe95.camel@intel.com> References: <20190709122345.29180-1-arkadiusz.hiler@intel.com> <20190709122345.29180-3-arkadiusz.hiler@intel.com> In-Reply-To: <20190709122345.29180-3-arkadiusz.hiler@intel.com> Content-Language: en-US Content-ID: MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 3/3] runner: Make sure that we are closing watchdogs on signals List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Hiler, Arkadiusz" , "igt-dev@lists.freedesktop.org" Cc: "Latvala, Petri" List-ID: T24gVHVlLCAyMDE5LTA3LTA5IGF0IDE1OjIzICswMzAwLCBBcmthZGl1c3ogSGlsZXIgd3JvdGU6 DQo+IFRoZXJlIGFyZSBmZXcgc2hvcnQgd2luZG93cyBvZiBvcHBvcnR1bml0eSB3aGVuIHdhdGNo ZG9ncyBhcmUgcHJpbWVkIGJ1dA0KPiB0aGVyZSBpcyBubyBzaWduYWwgaGFuZGxpbmcgaW4gcGxh Y2UsIHNvIHRoZSBwcm9jZXNzIG1heSBleGl0IHdpdGhvdXQNCj4gcHJvcGVyIHNodXRkb3duIHNl cXVlbmNlLg0KPiANCj4gVGhpcyBwYXRjaCByZWFycmFuZ2VzIHRoZSBleGlzdGluZyBjb2RlIHNv IHRoYXQgd2Ugc2V0IHVwIHRoZSBzaWduYWxmZA0KPiBhbmQgQkxPQ0sgdGhlIHNpZ25hbHMgYmVm b3JlIHNldHRpbmcgdXAgd2F0Y2hkb2dzIGFuZCBVTkJMT0NLIG9ubHkgYWZ0ZXINCj4gdGhlIHdh dGNoZG9ncyBhcmUgY2xvc2VkIHByb3Blcmx5Lg0KPiANCj4gSWYgaWd0X3J1bm5lciBleGl0cyBk dWUgdG8gc2lnbmFsLCBub24temVybyBzdGF0dXMgY29kZSBpcyByZXR1cm5lZC4NCj4gDQo+IENj OiBQZXRyaSBMYXR2YWxhIDxwZXRyaS5sYXR2YWxhQGludGVsLmNvbT4NCj4gU2lnbmVkLW9mZi1i eTogQXJrYWRpdXN6IEhpbGVyIDxhcmthZGl1c3ouaGlsZXJAaW50ZWwuY29tPg0KPiAtLS0NCj4g IHJ1bm5lci9leGVjdXRvci5jIHwgMTAwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0tLS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCA3MyBpbnNlcnRpb25zKCspLCAyNyBk ZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9ydW5uZXIvZXhlY3V0b3IuYyBiL3J1bm5l ci9leGVjdXRvci5jDQo+IGluZGV4IDY0NjNhYjk2Li42MjMwM2ZmOCAxMDA2NDQNCj4gLS0tIGEv cnVubmVyL2V4ZWN1dG9yLmMNCj4gKysrIGIvcnVubmVyL2V4ZWN1dG9yLmMNCj4gQEAgLTcsNiAr Nyw3IEBADQo+ICAjaW5jbHVkZSA8c3RyaW5nLmg+DQo+ICAjaW5jbHVkZSA8c3lzL2lvY3RsLmg+ DQo+ICAjaW5jbHVkZSA8c3lzL3NlbGVjdC5oPg0KPiArI2luY2x1ZGUgPHN5cy9wb2xsLmg+DQo+ ICAjaW5jbHVkZSA8c3lzL3NpZ25hbGZkLmg+DQo+ICAjaW5jbHVkZSA8c3lzL3N0YXQuaD4NCj4g ICNpbmNsdWRlIDxzeXMvdGltZS5oPg0KPiBAQCAtNjA0LDcgKzYwNSw2IEBAIHN0YXRpYyBpbnQg bW9uaXRvcl9vdXRwdXQocGlkX3QgY2hpbGQsDQo+ICAJCQkJY2xvc2Uob3V0ZmQpOw0KPiAgCQkJ CWNsb3NlKGVycmZkKTsNCj4gIAkJCQljbG9zZShrbXNnZmQpOw0KPiAtCQkJCWNsb3NlKHNpZ2Zk KTsNCj4gIAkJCQlyZXR1cm4gLTE7DQo+ICAJCQl9DQo+ICANCj4gQEAgLTc3Niw5ICs3NzYsOCBA QCBzdGF0aWMgaW50IG1vbml0b3Jfb3V0cHV0KHBpZF90IGNoaWxkLA0KPiAgCQkJCQkqdGltZV9z cGVudCA9IHRpbWU7DQo+ICAJCQl9DQo+ICANCj4gLQkJCWNsb3NlKHNpZ2ZkKTsNCj4gLQkJCXNp Z2ZkID0gLTE7DQo+ICAJCQljaGlsZCA9IDA7DQo+ICsJCQlzaWdmZCA9IC0xOyAvKiB3ZSBhcmUg ZHlpbmcsIG5vIHNpZ25hbCBoYW5kbGluZyBmb3Igbm93ICovDQo+ICAJCX0NCj4gIAl9DQo+ICAN Cj4gQEAgLTc5MCw3ICs3ODksNiBAQCBzdGF0aWMgaW50IG1vbml0b3Jfb3V0cHV0KHBpZF90IGNo aWxkLA0KPiAgCWNsb3NlKG91dGZkKTsNCj4gIAljbG9zZShlcnJmZCk7DQo+ICAJY2xvc2Uoa21z Z2ZkKTsNCj4gLQljbG9zZShzaWdmZCk7DQo+ICANCj4gIAlpZiAoYWJvcnRpbmcpDQo+ICAJCXJl dHVybiAtMTsNCj4gQEAgLTkwOCwxMyArOTA2LDEyIEBAIHN0YXRpYyBpbnQgZXhlY3V0ZV9uZXh0 X2VudHJ5KHN0cnVjdCBleGVjdXRlX3N0YXRlICpzdGF0ZSwNCj4gIAkJCSAgICAgIGRvdWJsZSAq dGltZV9zcGVudCwNCj4gIAkJCSAgICAgIHN0cnVjdCBzZXR0aW5ncyAqc2V0dGluZ3MsDQo+ICAJ CQkgICAgICBzdHJ1Y3Qgam9iX2xpc3RfZW50cnkgKmVudHJ5LA0KPiAtCQkJICAgICAgaW50IHRl c3RkaXJmZCwgaW50IHJlc2RpcmZkKQ0KPiArCQkJICAgICAgaW50IHRlc3RkaXJmZCwgaW50IHJl c2RpcmZkLA0KPiArCQkJICAgICAgaW50IHNpZ2ZkLCBzaWdzZXRfdCAqc2lnbWFzaykNCj4gIHsN Cj4gIAlpbnQgZGlyZmQ7DQo+ICAJaW50IG91dHB1dHNbX0ZfTEFTVF07DQo+ICAJaW50IGttc2dm ZDsNCj4gLQlpbnQgc2lnZmQ7DQo+IC0Jc2lnc2V0X3QgbWFzazsNCj4gIAlpbnQgb3V0cGlwZVsy XSA9IHsgLTEsIC0xIH07DQo+ICAJaW50IGVycnBpcGVbMl0gPSB7IC0xLCAtMSB9Ow0KPiAgCWlu dCBvdXRmZCwgZXJyZmQ7DQo+IEBAIC05NTQsMjEgKzk1MSw2IEBAIHN0YXRpYyBpbnQgZXhlY3V0 ZV9uZXh0X2VudHJ5KHN0cnVjdCBleGVjdXRlX3N0YXRlICpzdGF0ZSwNCj4gIAkJbHNlZWsoa21z Z2ZkLCAwLCBTRUVLX0VORCk7DQo+ICAJfQ0KPiAgDQo+IC0Jc2lnZW1wdHlzZXQoJm1hc2spOw0K PiAtCXNpZ2FkZHNldCgmbWFzaywgU0lHQ0hMRCk7DQo+IC0Jc2lnYWRkc2V0KCZtYXNrLCBTSUdJ TlQpOw0KPiAtCXNpZ2FkZHNldCgmbWFzaywgU0lHVEVSTSk7DQo+IC0Jc2lnYWRkc2V0KCZtYXNr LCBTSUdRVUlUKTsNCj4gLQlzaWdhZGRzZXQoJm1hc2ssIFNJR0hVUCk7DQo+IC0Jc2lncHJvY21h c2soU0lHX0JMT0NLLCAmbWFzaywgTlVMTCk7DQo+IC0Jc2lnZmQgPSBzaWduYWxmZCgtMSwgJm1h c2ssIE9fQ0xPRVhFQyk7DQo+IC0NCj4gLQlpZiAoc2lnZmQgPCAwKSB7DQo+IC0JCS8qIFRPRE86 IEhhbmRsZSBiZXR0ZXIgKi8NCj4gLQkJZnByaW50ZihzdGRlcnIsICJDYW5ub3QgbW9uaXRvciBj aGlsZCBwcm9jZXNzIHdpdGggc2lnbmFsZmRcbiIpOw0KPiAtCQlyZXN1bHQgPSAtMTsNCj4gLQkJ Z290byBvdXRfa21zZ2ZkOw0KPiAtCX0NCj4gIA0KPiAgCWlmIChzZXR0aW5ncy0+bG9nX2xldmVs ID49IExPR19MRVZFTF9OT1JNQUwpIHsNCj4gIAkJY2hhciAqZGlzcGxheW5hbWU7DQo+IEBAIC0x MDAyLDcgKzk4NCw3IEBAIHN0YXRpYyBpbnQgZXhlY3V0ZV9uZXh0X2VudHJ5KHN0cnVjdCBleGVj dXRlX3N0YXRlICpzdGF0ZSwNCj4gIAkJY2xvc2Uob3V0cGlwZVswXSk7DQo+ICAJCWNsb3NlKGVy cnBpcGVbMF0pOw0KPiAgDQo+IC0JCXNpZ3Byb2NtYXNrKFNJR19VTkJMT0NLLCAmbWFzaywgTlVM TCk7DQo+ICsJCXNpZ3Byb2NtYXNrKFNJR19VTkJMT0NLLCBzaWdtYXNrLCBOVUxMKTsNCj4gIA0K PiAgCQlzZXRlbnYoIklHVF9TRU5USU5FTF9PTl9TVERFUlIiLCAiMSIsIDEpOw0KPiAgDQo+IEBA IC0xMjYxLDEyICsxMjQzLDQxIEBAIHN0YXRpYyB2b2lkIG9vbV9pbW1vcnRhbCh2b2lkKQ0KPiAg CWNsb3NlKGZkKTsNCj4gIH0NCj4gIA0KPiArc3RhdGljIGJvb2wgc2hvdWxkX2RpZV9iZWNhdXNl X3NpZ25hbChpbnQgc2lnZmQpDQo+ICt7DQo+ICsJc3RydWN0IHNpZ25hbGZkX3NpZ2luZm8gc2ln aW5mbzsNCj4gKwlpbnQgcmV0Ow0KPiArDQo+ICsJc3RydWN0IHBvbGxmZCBzaWdwb2xsID0geyAu ZmQgPSBzaWdmZCwgLmV2ZW50cyA9IFBPTExJTiB8IFBPTExSREJBTkQgfTsNCj4gKw0KPiArCWlm ICgocmV0ID0gcG9sbCgmc2lncG9sbCwgMSwgMCkpICE9IDApIHsNCj4gKwkJaWYgKHJldCA9PSAt MSkgew0KDQpTZWVtcyBsaWtlIHRoaXMgaXMgdW5pbnRlbnRpb25hbGx5IGxlZnQgYmxhbmsuDQoN Cj4gKwkJfQ0KPiArDQo+ICsJCXJldCA9IHJlYWQoc2lnZmQsICZzaWdpbmZvLCBzaXplb2Yoc2ln aW5mbykpOw0KDQpFcnJvciBoYW5kbGluZyBpcyBtaXNzaW5nIChyZXQgPT0gc2l6ZW9mKHNpZ2lu Zm8pKS4NCg0KPiArCQlpZiAoc2lnaW5mby5zc2lfc2lnbm8gPT0gU0lHQ0hMRCkgew0KPiArCQkJ ZnByaW50ZihzdGRlcnIsICJSdW5uZXIgZ290IHN0cmF5IFNJR0NITEQgd2hpbGUgbm90IGV4ZWN1 dGluZyBhbnkgdGVzdHMuXG4iKTsNCj4gKw0KDQpOaXQ6IGV4dHJhIGJsYW5rIGxpbmUgaGVyZQ0K DQo+ICsJCX0gZWxzZSB7DQo+ICsJCQlmcHJpbnRmKHN0ZGVyciwgIlJ1bm5lciBpcyBiZWluZyBr aWxsZWQgYnkgJXNcbiIsDQo+ICsJCQkJc3Ryc2lnbmFsKHNpZ2luZm8uc3NpX3NpZ25vKSk7DQo+ ICsJCQlyZXR1cm4gdHJ1ZTsNCj4gKwkJfQ0KPiArDQo+ICsJfQ0KPiArDQo+ICsJcmV0dXJuIGZh bHNlOw0KPiArfQ0KPiArDQo+ICBib29sIGV4ZWN1dGUoc3RydWN0IGV4ZWN1dGVfc3RhdGUgKnN0 YXRlLA0KPiAgCSAgICAgc3RydWN0IHNldHRpbmdzICpzZXR0aW5ncywNCj4gIAkgICAgIHN0cnVj dCBqb2JfbGlzdCAqam9iX2xpc3QpDQo+ICB7DQo+ICAJc3RydWN0IHV0c25hbWUgdW5hbWVidWY7 DQo+ICAJaW50IHJlc2RpcmZkLCB0ZXN0ZGlyZmQsIHVuYW1lZmQsIHRpbWVmZDsNCj4gKwlzaWdz ZXRfdCBzaWdtYXNrOw0KPiArCWludCBzaWdmZDsNCj4gIAlkb3VibGUgdGltZV9zcGVudCA9IDAu MDsNCj4gIAlib29sIHN0YXR1cyA9IHRydWU7DQo+ICANCj4gQEAgLTEzMTAsNiArMTMyMSwyMiBA QCBib29sIGV4ZWN1dGUoc3RydWN0IGV4ZWN1dGVfc3RhdGUgKnN0YXRlLA0KPiAgDQo+ICAJb29t X2ltbW9ydGFsKCk7DQo+ICANCj4gKwlzaWdlbXB0eXNldCgmc2lnbWFzayk7DQo+ICsJc2lnYWRk c2V0KCZzaWdtYXNrLCBTSUdDSExEKTsNCj4gKwlzaWdhZGRzZXQoJnNpZ21hc2ssIFNJR0lOVCk7 DQo+ICsJc2lnYWRkc2V0KCZzaWdtYXNrLCBTSUdURVJNKTsNCj4gKwlzaWdhZGRzZXQoJnNpZ21h c2ssIFNJR1FVSVQpOw0KPiArCXNpZ2FkZHNldCgmc2lnbWFzaywgU0lHSFVQKTsNCj4gKwlzaWdm ZCA9IHNpZ25hbGZkKC0xLCAmc2lnbWFzaywgT19DTE9FWEVDKTsNCj4gKwlzaWdwcm9jbWFzayhT SUdfQkxPQ0ssICZzaWdtYXNrLCBOVUxMKTsNCj4gKw0KPiArCWlmIChzaWdmZCA8IDApIHsNCj4g KwkJLyogVE9ETzogSGFuZGxlIGJldHRlciAqLw0KPiArCQlmcHJpbnRmKHN0ZGVyciwgIkNhbm5v dCBtYXNrIHNpZ25hbHNcbiIpOw0KPiArCQlzdGF0dXMgPSAtMTsNCg0KVGhpcyBzaG91bGQgcHJv YmFibHkgYmUgYHN0YXR1cyA9IGZhbHNlYC4gLTEgaXMgYSB0cnV0aHkgdmFsdWUuDQoNCj4gKwkJ Z290byBlbmQ7DQo+ICsJfQ0KPiArDQo+ICAJaW5pdF93YXRjaGRvZ3Moc2V0dGluZ3MpOw0KPiAg DQo+ICAJaWYgKCF1bmFtZSgmdW5hbWVidWYpKSB7DQo+IEBAIC0xMzQ1LDEyICsxMzcyLDE4IEBA IGJvb2wgZXhlY3V0ZShzdHJ1Y3QgZXhlY3V0ZV9zdGF0ZSAqc3RhdGUsDQo+ICAJCWNoYXIgKnJl YXNvbjsNCj4gIAkJaW50IHJlc3VsdDsNCj4gIA0KPiArCQlpZiAoc2hvdWxkX2RpZV9iZWNhdXNl X3NpZ25hbChzaWdmZCkpIHsNCj4gKwkJCXN0YXR1cyA9IGZhbHNlOw0KDQpTaG91bGQgd2UgY2xv c2Vfd2F0Y2hkb2dzIGF0IHRoaXMgcG9pbnQ/DQoNCj4gKwkJCWdvdG8gZW5kOw0KPiArCQl9DQo+ ICsNCj4gIAkJcmVzdWx0ID0gZXhlY3V0ZV9uZXh0X2VudHJ5KHN0YXRlLA0KPiAgCQkJCQkgICAg am9iX2xpc3QtPnNpemUsDQo+ICAJCQkJCSAgICAmdGltZV9zcGVudCwNCj4gIAkJCQkJICAgIHNl dHRpbmdzLA0KPiAgCQkJCQkgICAgJmpvYl9saXN0LT5lbnRyaWVzW3N0YXRlLT5uZXh0XSwNCj4g LQkJCQkJICAgIHRlc3RkaXJmZCwgcmVzZGlyZmQpOw0KPiArCQkJCQkgICAgdGVzdGRpcmZkLCBy ZXNkaXJmZCwNCj4gKwkJCQkJICAgIHNpZ2ZkLCAmc2lnbWFzayk7DQoNClRoZSBhcmd1bWVudCBs aXN0IGlzIGdldHRpbmcgcXVpdGUgbGFyZ2UuIEF0IHNvbWUgcG9pbnQgaXQgbWF5IGJlIHdvcnRo DQppdCB0byBwdXQgZXZlcnl0aGluZyAob3IgcGFydCBvZiB0aGVzZSkgaW4gYSBzdHJ1Y3QuDQoN CihJbiBnZW5lcmFsIEkgZmVlbCBsaWtlIHRoaXMgZmlsZSBjb3VsZCBiZSBpbXByb3ZlZCBhIGxv dCwgdGhlc2UgbG9uZw0KZnVuY3Rpb25zIGFyZSBoYXJkIHRvIHJlYWQuKQ0KDQo+ICANCj4gIAkJ aWYgKHJlc3VsdCA8IDApIHsNCj4gIAkJCXN0YXR1cyA9IGZhbHNlOw0KPiBAQCAtMTM4Myw4ICsx NDE2LDE1IEBAIGJvb2wgZXhlY3V0ZShzdHJ1Y3QgZXhlY3V0ZV9zdGF0ZSAqc3RhdGUsDQo+ICAJ CWlmIChyZXN1bHQgPiAwKSB7DQo+ICAJCQlkb3VibGUgdGltZV9sZWZ0ID0gc3RhdGUtPnRpbWVf bGVmdDsNCj4gIA0KPiAtCQkJY2xvc2UodGVzdGRpcmZkKTsNCj4gIAkJCWNsb3NlX3dhdGNoZG9n cyhzZXR0aW5ncyk7DQo+ICsJCQlzaWdwcm9jbWFzayhTSUdfVU5CTE9DSywgJnNpZ21hc2ssIE5V TEwpOw0KPiArCQkJLyogbWFrZSBzdXJlIHRoYXQgd2UgZG8gbm90IGxlYXZlIGFueSBzaWduYWxz IHVuaGFuZGxlZCAqLw0KPiArCQkJaWYgKHNob3VsZF9kaWVfYmVjYXVzZV9zaWduYWwoc2lnZmQp KXsNCg0KU3R5bGUgbml0OiBtaXNzaW5nIHNwYWNlIGJldHdlZW4gYClgIGFuZCBge2AuDQoNCj4g KwkJCQlzdGF0dXMgPSBmYWxzZTsNCj4gKwkJCQlnb3RvIGVuZF9wb3N0X3NpZ25hbF9yZXN0b3Jl Ow0KPiArCQkJfQ0KPiArCQkJY2xvc2Uoc2lnZmQpOw0KPiArCQkJY2xvc2UodGVzdGRpcmZkKTsN Cj4gIAkJCWluaXRpYWxpemVfZXhlY3V0ZV9zdGF0ZV9mcm9tX3Jlc3VtZShyZXNkaXJmZCwgc3Rh dGUsIHNldHRpbmdzLCBqb2JfbGlzdCk7DQo+ICAJCQlzdGF0ZS0+dGltZV9sZWZ0ID0gdGltZV9s ZWZ0Ow0KPiAgCQkJcmV0dXJuIGV4ZWN1dGUoc3RhdGUsIHNldHRpbmdzLCBqb2JfbGlzdCk7DQo+ IEBAIC0xMzk3LDggKzE0MzcsMTQgQEAgYm9vbCBleGVjdXRlKHN0cnVjdCBleGVjdXRlX3N0YXRl ICpzdGF0ZSwNCj4gIAl9DQo+ICANCj4gICBlbmQ6DQo+IC0JY2xvc2UodGVzdGRpcmZkKTsNCj4g LQljbG9zZShyZXNkaXJmZCk7DQo+ICAJY2xvc2Vfd2F0Y2hkb2dzKHNldHRpbmdzKTsNCj4gKwlz aWdwcm9jbWFzayhTSUdfVU5CTE9DSywgJnNpZ21hc2ssIE5VTEwpOw0KPiArCS8qIG1ha2Ugc3Vy ZSB0aGF0IHdlIGRvIG5vdCBsZWF2ZSBhbnkgc2lnbmFscyB1bmhhbmRsZWQgKi8NCj4gKwlpZiAo c2hvdWxkX2RpZV9iZWNhdXNlX3NpZ25hbChzaWdmZCkpDQo+ICsJCXN0YXR1cyA9IGZhbHNlOw0K PiArIGVuZF9wb3N0X3NpZ25hbF9yZXN0b3JlOg0KPiArCWNsb3NlKHNpZ2ZkKTsNCj4gKwljbG9z ZSh0ZXN0ZGlyZmQpOw0KPiArCWNsb3NlKHJlc2RpcmZkKTsNCj4gIAlyZXR1cm4gc3RhdHVzOw0K PiAgfQ0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0 LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2