From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id BC3FB6E16D for ; Fri, 7 Dec 2018 07:37:42 +0000 (UTC) Message-ID: <9944952dd93bcb1c3fb9ecd5f55b71f43407a2bd.camel@bootlin.com> From: Paul Kocialkowski Date: Fri, 07 Dec 2018 08:37:41 +0100 In-Reply-To: References: <20181206141132.23349-1-paul.kocialkowski@bootlin.com> <20181206141132.23349-2-paul.kocialkowski@bootlin.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 1/9] chamelium: Pass dimensions instead of mode to pattern generation helper List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Lyude Paul , igt-dev@lists.freedesktop.org Cc: Petri Latvala , Eben Upton , Thomas Petazzoni List-ID: SGksCgpPbiBUaHUsIDIwMTgtMTItMDYgYXQgMTY6NDMgLTA1MDAsIEx5dWRlIFBhdWwgd3JvdGU6 Cj4gQXJlIHRoZXJlIHNvbWUgcGF0Y2hlcyBtaXNzaW5nIGhlcmU/IFRoaXMgZG9lc24ndCBzZWVt IHRvIGFwcGx5IGNsZWFubHkgdG8KPiBtYXN0ZXIsIGFuZCBpdCBsb29rcyBsaWtlIHRoaXMgaXMg cmVseWluZyBvbiBzb21lIGNoYW5nZXMgdG8KPiBjaGFtZWxpdW1fcGFpbnRfeHIyNF9wYXR0ZXJu KCkgdGhhdCBhcmVuJ3QgaW4gdGhlIHRyZWUKClllcywgdGhlcmUgYXJlIGRlZmluaXRlbHkgbWlz c2luZyBwYXRjaGVzIGluIHRoaXMgc2VyaWVzISBJdCdzCm1lbnRpb25uZWQgaW4gdGhlIGNvdmVy IGxldHRlciwgd2hlcmUgaXQgc2F5czogCgpUaGlzIHNlcmllcyBpcyBiYXNlZCBvbiBNYXhpbWUg UmlwYXJkJ3Mgc2VyaWVzOgogIGlndDogY2hhbWVsaXVtOiBUZXN0IFlVViBidWZmZXJzIHVzaW5n IHRoZSBDaGFtZWxpdW0KCndoaWNoIHdhcyBub3QgbWVyZ2VkIHlldC4gTWF5YmUgSSBzaG91bGQg YmV0dGVyIGluY2x1ZGUgdGhlIHBhdGNoZXMgSQpuZWVkIGluIG15IHNlcmllcyBuZXh0IHRpbWU/ Cgo+IChvdGhlcndpc2UsIHRoaXMgcGF0Y2ggbGd0bSwgUmV2aWV3ZWQtYnk6IEx5dWRlIFBhdWwg PGx5dWRlQHJlZGhhdC5jb20+KQoKVGhhbmtzIGZvciByZXZpZXdpbmcgdGhlIHNlcmllcyEKCkNo ZWVycywKClBhdWwKCj4gT24gVGh1LCAyMDE4LTEyLTA2IGF0IDE1OjExICswMTAwLCBQYXVsIEtv Y2lhbGtvd3NraSB3cm90ZToKPiA+IEluIG9yZGVyIHRvIHJldXNlIHRoZSBwYXR0ZXJuIGdlbmVy YXRpb24gaGVscGVyIGZvciBvdmVybGF5IHBsYW5lcywKPiA+IGxldCdzIHByb3ZpZGUgdGhlIHBh dHRlcm4gZ2VuZXJhdGlvbiBoZWxwZXIgd2l0aCB0aGUgZXhwbGljaXQgZGltZW5zaW9ucwo+ID4g aW5zdGVhZCBvZiB0aGUgbW9kZSAodGhhdCBvbmx5IGFwcGxpZXMgdG8gdGhlIHByaW1hcnkgcGxh bmUpLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBQYXVsIEtvY2lhbGtvd3NraSA8cGF1bC5rb2Np YWxrb3dza2lAYm9vdGxpbi5jb20+Cj4gPiAtLS0KPiA+ICB0ZXN0cy9rbXNfY2hhbWVsaXVtLmMg fCAxMSArKysrKy0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDYg ZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS90ZXN0cy9rbXNfY2hhbWVsaXVtLmMg Yi90ZXN0cy9rbXNfY2hhbWVsaXVtLmMKPiA+IGluZGV4IDhhOWY2YmZlLi5iOGNhYjkyNyAxMDA2 NDQKPiA+IC0tLSBhL3Rlc3RzL2ttc19jaGFtZWxpdW0uYwo+ID4gKysrIGIvdGVzdHMva21zX2No YW1lbGl1bS5jCj4gPiBAQCAtNTA0LDcgKzUwNCw3IEBAIHN0YXRpYyB2b2lkIGNoYW1lbGl1bV9w YWludF94cjI0X3BhdHRlcm4odWludDMyX3QgKmRhdGEsCj4gPiAgCQkJKihkYXRhICsgaSAqIHN0 cmlkZSAvIDQgKyBqKSA9IGNvbG9yc1soKGogLyA2NCkgKyAoaSAvCj4gPiA2NCkpICUgNV07Cj4g PiAgfQo+ID4gIAo+ID4gLXN0YXRpYyBpbnQgY2hhbWVsaXVtX2dldF9wYXR0ZXJuX2ZiKGRhdGFf dCAqZGF0YSwgZHJtTW9kZU1vZGVJbmZvICptb2RlLAo+ID4gK3N0YXRpYyBpbnQgY2hhbWVsaXVt X2dldF9wYXR0ZXJuX2ZiKGRhdGFfdCAqZGF0YSwgc2l6ZV90IHdpZHRoLCBzaXplX3QKPiA+IGhl aWdodCwKPiA+ICAJCQkJICAgIHVpbnQzMl90IGZvdXJjYywgc3RydWN0IGlndF9mYiAqZmIpCj4g PiAgewo+ID4gIAlpbnQgZmJfaWQ7Cj4gPiBAQCAtNTEyLDE1ICs1MTIsMTQgQEAgc3RhdGljIGlu dCBjaGFtZWxpdW1fZ2V0X3BhdHRlcm5fZmIoZGF0YV90ICpkYXRhLAo+ID4gZHJtTW9kZU1vZGVJ bmZvICptb2RlLAo+ID4gIAo+ID4gIAlpZ3RfYXNzZXJ0KGZvdXJjYyA9PSBEUk1fRk9STUFUX1hS R0I4ODg4KTsKPiA+ICAKPiA+IC0JZmJfaWQgPSBpZ3RfY3JlYXRlX2ZiKGRhdGEtPmRybV9mZCwg bW9kZS0+aGRpc3BsYXksIG1vZGUtPnZkaXNwbGF5LAo+ID4gLQkJCSAgICAgIGZvdXJjYywgTE9D QUxfRFJNX0ZPUk1BVF9NT0RfTk9ORSwgZmIpOwo+ID4gKwlmYl9pZCA9IGlndF9jcmVhdGVfZmIo ZGF0YS0+ZHJtX2ZkLCB3aWR0aCwgaGVpZ2h0LCBmb3VyY2MsCj4gPiArCQkJICAgICAgTE9DQUxf RFJNX0ZPUk1BVF9NT0RfTk9ORSwgZmIpOwo+ID4gIAlpZ3RfYXNzZXJ0KGZiX2lkID4gMCk7Cj4g PiAgCj4gPiAgCXB0ciA9IGlndF9mYl9tYXBfYnVmZmVyKGZiLT5mZCwgZmIpOwo+ID4gIAlpZ3Rf YXNzZXJ0KHB0cik7Cj4gPiAgCj4gPiAtCWNoYW1lbGl1bV9wYWludF94cjI0X3BhdHRlcm4ocHRy LCBtb2RlLT5oZGlzcGxheSwgbW9kZS0+dmRpc3BsYXksCj4gPiAtCQkJCSAgICAgZmItPnN0cmlk ZXNbMF0pOwo+ID4gKwljaGFtZWxpdW1fcGFpbnRfeHIyNF9wYXR0ZXJuKHB0ciwgd2lkdGgsIGhl aWdodCwgZmItPnN0cmlkZXNbMF0pOwo+ID4gIAlpZ3RfZmJfdW5tYXBfYnVmZmVyKGZiLCBwdHIp Owo+ID4gIAo+ID4gIAlyZXR1cm4gZmJfaWQ7Cj4gPiBAQCAtNTQxLDcgKzU0MCw3IEBAIHN0YXRp YyB2b2lkIGRvX3Rlc3RfZGlzcGxheShkYXRhX3QgKmRhdGEsIHN0cnVjdAo+ID4gY2hhbWVsaXVt X3BvcnQgKnBvcnQsCj4gPiAgCWludCBpLCBmYl9pZCwgY2FwdHVyZWRfZnJhbWVfY291bnQ7Cj4g PiAgCWludCBmcmFtZV9pZDsKPiA+ICAKPiA+IC0JZmJfaWQgPSBjaGFtZWxpdW1fZ2V0X3BhdHRl cm5fZmIoZGF0YSwgbW9kZSwKPiA+ICsJZmJfaWQgPSBjaGFtZWxpdW1fZ2V0X3BhdHRlcm5fZmIo ZGF0YSwgbW9kZS0+aGRpc3BsYXksIG1vZGUtPnZkaXNwbGF5LAo+ID4gIAkJCQkJIERSTV9GT1JN QVRfWFJHQjg4ODgsICZmYik7Cj4gPiAgCWlndF9hc3NlcnQoZmJfaWQgPiAwKTsKPiA+ICAKLS0g ClBhdWwgS29jaWFsa293c2tpLCBCb290bGluIChmb3JtZXJseSBGcmVlIEVsZWN0cm9ucykKRW1i ZWRkZWQgTGludXggYW5kIGtlcm5lbCBlbmdpbmVlcmluZwpodHRwczovL2Jvb3RsaW4uY29tCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1h aWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK