Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>
To: "Thasleem, Mohammed" <mohammed.thasleem@intel.com>,
	<igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_atomic_transition: Reduce the execution time on modest-transition
Date: Thu, 31 Aug 2023 22:19:39 +0530	[thread overview]
Message-ID: <998db4f9-0f2a-f4b3-581f-7760ebad19ae@intel.com> (raw)
In-Reply-To: <20230829161759.9315-1-mohammed.thasleem@intel.com>

Hi Thasleem,

On Tue-29-08-2023 09:47 pm, Thasleem, Mohammed wrote:
> Due to the more number of iterations, "modest-transition" tests are
> getting timed out on CI. Reducing the number of iterations to half
> can save a lot of execution time.
> 
> Signed-off-by: Thasleem, Mohammed <mohammed.thasleem@intel.com>
> ---
>   tests/kms_atomic_transition.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
> index a470eb88c..690202271 100644
> --- a/tests/kms_atomic_transition.c
> +++ b/tests/kms_atomic_transition.c
> @@ -966,10 +966,7 @@ retry:
>   		}
>   	}
>   
> -	iter_max = 1 << j;
> -
> -	if (igt_run_in_simulation() && iter_max > 1)
> -		iter_max = iter_max >> 1;
> +	iter_max = j << 1;

Looks this logic is not correct & it will not make the iter_max to half.

Please check below table:

j  | 1 << j | j << 1
---------------------
0  |    1   |   0
1  |    2   |   2
2  |    4   |   4
3  |    8   |   6
4  |   16   |   8
5  |   32   |   10

- Bhanu

>   
>   	if (igt_display_try_commit_atomic(&data->display,
>   				DRM_MODE_ATOMIC_TEST_ONLY |

  parent reply	other threads:[~2023-08-31 16:50 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29 16:17 [igt-dev] [PATCH i-g-t] tests/kms_atomic_transition: Reduce the execution time on modest-transition Thasleem, Mohammed
2022-04-21 14:19 ` [igt-dev] [PATCH i-g-t] tests/kms_atomic_transition: Reduce the number of iterations on modeset-transition Mohammed Thasleem
2023-09-07  5:40   ` Modem, Bhanuprakash
2023-09-07  7:58   ` Kamil Konieczny
2022-04-23 23:26 ` Mohammed Thasleem
2023-08-29 12:10 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_atomic_transition: Reduce the execution time on modest-transition Patchwork
2023-08-29 12:42 ` [igt-dev] ✓ CI.xeBAT: success " Patchwork
2023-08-29 12:51 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-08-29 18:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-08-30 13:51 ` [igt-dev] [PATCH i-g-t] " Kamil Konieczny
2023-08-31  8:52   ` Sharma, Swati2
2023-08-31 16:49 ` Modem, Bhanuprakash [this message]
2023-09-03 19:26 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_atomic_transition: Reduce the execution time on modest-transition (rev2) Patchwork
2023-09-03 19:53 ` [igt-dev] ✓ CI.xeBAT: success " Patchwork
2023-09-03 20:03 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-09-03 21:48 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-04 18:13 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_atomic_transition: Reduce the execution time on modest-transition (rev3) Patchwork
2023-09-04 18:40 ` [igt-dev] ✓ CI.xeBAT: success " Patchwork
2023-09-04 18:48 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2023-09-07  8:54 ` [igt-dev] [PATCH i-g-t] tests/kms_atomic_transition: Reduce the number of iterations on modeset-transition Mohammed Thasleem
2023-09-07 11:59   ` Kamil Konieczny
2023-09-07 10:36 ` [igt-dev] ✓ CI.xeBAT: success for tests/kms_atomic_transition: Reduce the execution time on modest-transition (rev4) Patchwork
2023-09-07 10:46 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2023-09-08 13:50 ` [igt-dev] [PATCH i-g-t] tests/kms_atomic_transition: Reduce the number of iterations on modeset-transition Mohammed Thasleem
2023-09-12 12:05 ` [igt-dev] ✓ CI.xeBAT: success for tests/kms_atomic_transition: Reduce the execution time on modest-transition (rev6) Patchwork
2023-09-12 12:16 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2023-09-13  9:00 ` Patchwork
2023-09-13  9:27 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-09-13 10:39 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-13 12:58 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=998db4f9-0f2a-f4b3-581f-7760ebad19ae@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mohammed.thasleem@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox