From: Karolina Stolarek <karolina.stolarek@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
igt-dev@lists.freedesktop.org
Cc: Akshata Jahagirdar <akshata.jahagirdar@intel.com>
Subject: Re: [PATCH i-g-t v2 1/2] lib/intel_blt: Add functions which extract and check object ccs data
Date: Wed, 10 Apr 2024 12:51:16 +0200 [thread overview]
Message-ID: <999399c3-b702-4a79-b7a2-3c96654938ee@intel.com> (raw)
In-Reply-To: <20240410100915.48541-2-zbigniew.kempczynski@intel.com>
On 10.04.2024 12:09, Zbigniew Kempczyński wrote:
> In tests which use compression we did very naive check in which we
> compare source and destination surface. For linear we could expect
> differences are related to compression, unfortunately for tiled data
> this attitude is not appropriate due to natural data layout difference.
>
> Lets add helpers to extract surface ccs data and check if such
> surface is compressed. Function which extracts ccs data is defined
> as public to dump such data to png in the future.
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Karolina Stolarek <karolina.stolarek@intel.com>
> Cc: Akshata Jahagirdar <akshata.jahagirdar@intel.com>
Looking good, thanks for addressing the comments I had:
Reviewed-by: Karolina Stolarek <karolina.stolarek@intel.com>
(applies to both patches)
All the best,
Karolina
next prev parent reply other threads:[~2024-04-10 10:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 10:09 [PATCH i-g-t v2 0/2] Add surface flat ccs check Zbigniew Kempczyński
2024-04-10 10:09 ` [PATCH i-g-t v2 1/2] lib/intel_blt: Add functions which extract and check object ccs data Zbigniew Kempczyński
2024-04-10 10:51 ` Karolina Stolarek [this message]
2024-04-10 14:36 ` Jahagirdar, Akshata
2024-04-10 10:09 ` [PATCH i-g-t v2 2/2] tests/gem|xe_ccs: Check surface ccs data instead of naive comparison Zbigniew Kempczyński
2024-04-10 14:36 ` Jahagirdar, Akshata
2024-04-10 23:24 ` ✓ CI.xeBAT: success for Add surface flat ccs check (rev2) Patchwork
2024-04-10 23:35 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-11 6:20 ` ✓ CI.xeBAT: success for Add surface flat ccs check (rev3) Patchwork
2024-04-11 6:25 ` ✓ Fi.CI.BAT: " Patchwork
2024-04-11 9:41 ` ✗ CI.xeFULL: failure for Add surface flat ccs check (rev2) Patchwork
2024-04-11 15:12 ` ✗ Fi.CI.IGT: failure for Add surface flat ccs check (rev3) Patchwork
2024-04-11 15:25 ` Zbigniew Kempczyński
2024-04-11 15:32 ` ✗ CI.xeFULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=999399c3-b702-4a79-b7a2-3c96654938ee@intel.com \
--to=karolina.stolarek@intel.com \
--cc=akshata.jahagirdar@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox