From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 45FB589A9A for ; Thu, 5 Mar 2020 06:21:25 +0000 (UTC) References: <1583324295-22013-1-git-send-email-kunal1.joshi@intel.com> From: "Sharma, Swati2" Message-ID: <9a06c2b1-798f-5335-6d24-883fca4558b4@intel.com> Date: Thu, 5 Mar 2020 11:51:21 +0530 MIME-Version: 1.0 In-Reply-To: <1583324295-22013-1-git-send-email-kunal1.joshi@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_chamelium: Add support to validate YUV pixel formats List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Kunal Joshi , igt-dev@lists.freedesktop.org Cc: petri.latvala@intel.com List-ID: Hi Kunal, Can we rewrite subtests for rgb pixel formats too in the same fashion as you did for yuv? On 04-Mar-20 5:48 PM, Kunal Joshi wrote: > Currently, only hard coded pixel formats are validated which are not > generic for all the platforms which leads to false alarms. > Added support to validate only those pixel formats which are supported > by platform. > > Signed-off-by: Kunal Joshi > --- > tests/kms_chamelium.c | 70 +++++++++++++++++++++++---------------------------- > 1 file changed, 32 insertions(+), 38 deletions(-) > > diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c > index 5c4a189..d6d63c6 100644 > --- a/tests/kms_chamelium.c > +++ b/tests/kms_chamelium.c > @@ -2612,6 +2612,14 @@ static const struct edid *get_edid(enum test_edid edid) > if (chamelium_port_get_type(port) == \ > DRM_MODE_CONNECTOR_ ## type__) > > +#define connector_subtest_start(name__, type__) \ > + igt_subtest_with_dynamic(name__) \ > + for_each_port(p, port) \ > + if (chamelium_port_get_type(port) == \ > + DRM_MODE_CONNECTOR_ ## type__) { > + > +#define connector_subtest_end } > + > static data_t data; > > IGT_TEST_DESCRIPTION("Tests requiring a Chamelium board"); > @@ -2872,44 +2880,30 @@ igt_main > CHAMELIUM_CHECK_CRC); > > igt_describe(test_display_one_mode_desc); > - connector_subtest("hdmi-cmp-nv12", HDMIA) > - test_display_one_mode(&data, port, DRM_FORMAT_NV12, > - CHAMELIUM_CHECK_CHECKERBOARD, 1); > - > - igt_describe(test_display_one_mode_desc); > - connector_subtest("hdmi-cmp-nv16", HDMIA) > - test_display_one_mode(&data, port, DRM_FORMAT_NV16, > - CHAMELIUM_CHECK_CHECKERBOARD, 1); > - > - igt_describe(test_display_one_mode_desc); > - connector_subtest("hdmi-cmp-nv21", HDMIA) > - test_display_one_mode(&data, port, DRM_FORMAT_NV21, > - CHAMELIUM_CHECK_CHECKERBOARD, 1); > - > - igt_describe(test_display_one_mode_desc); > - connector_subtest("hdmi-cmp-nv61", HDMIA) > - test_display_one_mode(&data, port, DRM_FORMAT_NV61, > - CHAMELIUM_CHECK_CHECKERBOARD, 1); > - > - igt_describe(test_display_one_mode_desc); > - connector_subtest("hdmi-cmp-yu12", HDMIA) > - test_display_one_mode(&data, port, DRM_FORMAT_YUV420, > - CHAMELIUM_CHECK_CHECKERBOARD, 1); > - > - igt_describe(test_display_one_mode_desc); > - connector_subtest("hdmi-cmp-yu16", HDMIA) > - test_display_one_mode(&data, port, DRM_FORMAT_YUV422, > - CHAMELIUM_CHECK_CHECKERBOARD, 1); > - > - igt_describe(test_display_one_mode_desc); > - connector_subtest("hdmi-cmp-yv12", HDMIA) > - test_display_one_mode(&data, port, DRM_FORMAT_YVU420, > - CHAMELIUM_CHECK_CHECKERBOARD, 1); > - > - igt_describe(test_display_one_mode_desc); > - connector_subtest("hdmi-cmp-yv16", HDMIA) > - test_display_one_mode(&data, port, DRM_FORMAT_YVU422, > - CHAMELIUM_CHECK_CHECKERBOARD, 1); > + connector_subtest_start("hdmi-yuv", HDMIA) Can we name test format like hdmi-yuv-format ? > + int k; > + igt_output_t *output; > + igt_plane_t *primary; > + > + output = prepare_output(&data, port, TEST_EDID_BASE); > + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); > + igt_assert(primary); > + > + for (k = 0; k < primary->format_mod_count; k++) { > + Extra \n? > + if (!igt_fb_supported_format(primary->formats[k])) > + continue; > + > + if (!(igt_format_is_yuv(primary->formats[k]) > + && primary->modifiers[k] != LOCAL_DRM_FORMAT_MOD_NONE)) > + continue; Nitpick: Can we but && in first line? > + > + igt_dynamic_f("%c%c%c%c", IGT_FORMAT_ARGS(primary->formats[k])) > + test_display_one_mode(&data, port, primary->formats[k], > + CHAMELIUM_CHECK_CHECKERBOARD, > + 1); > + } > + connector_subtest_end > > igt_describe(test_display_planes_random_desc); > connector_subtest("hdmi-cmp-planes-random", HDMIA) > Rest look good to me. -- ~Swati Sharma _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev