Re: [PATCH i-g-t] tests/intel/xe_query: Add test for PXP status query

["Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>]

Thanks for catching that ioctl return vs errno bug and the missing memory free - my bad for missing that:
Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>



On Thu, 2025-03-06 at 13:33 -0800, Ceraolo Spurio, Daniele wrote:
> Add a new test to exercise the PXP status query.
> 
> v2: fix ioctl error checking, free allocated mem
> 
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com> #v1
> ---
>  tests/intel/xe_query.c | 65 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 65 insertions(+)
> 
> diff --git a/tests/intel/xe_query.c b/tests/intel/xe_query.c
> index f5aa4a572..9c7bf1d6f 100644
> --- a/tests/intel/xe_query.c
> +++ b/tests/intel/xe_query.c
> @@ -1062,6 +1062,70 @@ static void test_query_oa_units(int fd)
>         }
>  }
>  
> +/**
> + * SUBTEST: query-pxp-status
> + * Description: Display PXP supported types and current status
> + *
> + * SUBTEST: multigpu-query-pxp-status
> + * Description: Display fields for PXP unit query for all Xe devices
> + * Sub-category: MultiGPU
> + */
> +static void test_query_pxp_status(int fd)
> +{
> +       struct drm_xe_query_pxp_status *qpxp;
> +       struct drm_xe_device_query query = {
> +               .extensions = 0,
> +               .query = DRM_XE_DEVICE_QUERY_PXP_STATUS,
> +               .size = 0,
> +               .data = 0,
> +       };
> +       int ret;
> +
> +       /*
> +        * if we run this test on an older kernel that doesn't have the PXP
> +        * query, the ioctl will return -EINVAL.
> +        */
> +       errno = 0;
> +       ret = igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query);
> +       igt_require(errno != EINVAL);
> +       igt_assert_eq(ret, 0);
> +
> +       /* make sure the returned size is big enough */
> +       igt_assert(query.size >= sizeof(*qpxp));
> +
> +       qpxp = malloc(query.size);
> +       igt_assert(qpxp);
> +
> +       memset(qpxp, 0, query.size);
> +
> +       query.data = to_user_pointer(qpxp);
> +
> +       errno = 0;
> +       ret = igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query);
> +       if (errno == ENODEV) {
> +               igt_info("PXP not supported\n");
> +               free(qpxp);
> +               return;
> +       }
> +
> +       igt_assert_eq(ret, 0);
> +       igt_assert_neq(qpxp->supported_session_types, 0);
> +
> +       switch (qpxp->status) {
> +       case 0:
> +               igt_info("PXP initialization still in progress\n");
> +               break;
> +       case 1:
> +               igt_info("PXP initialization complete\n");
> +               break;
> +       default:
> +               igt_assert_f(0, "unexpected PXP status %u\n", qpxp->status);
> +       }
> +
> +       igt_info("PXP supported types mask 0x%x\n", qpxp->supported_session_types);
> +       free(qpxp);
> +}
> +
>  igt_main
>  {
>         const struct {
> @@ -1079,6 +1143,7 @@ igt_main
>                 { "query-uc-fw-version-guc", test_query_uc_fw_version_guc },
>                 { "query-uc-fw-version-huc", test_query_uc_fw_version_huc },
>                 { "query-oa-units", test_query_oa_units },
> +               { "query-pxp-status", test_query_pxp_status },
>                 { "query-invalid-cs-cycles", test_engine_cycles_invalid },
>                 { "query-invalid-query", test_query_invalid_query },
>                 { "query-invalid-size", test_query_invalid_size },