From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Jeevan B <jeevan.b@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <pranay.samala@intel.com>
Subject: Re: [PATCH i-g-t] tests/kms_display_modes: Add check for ≥2 outputs in extended mode test
Date: Mon, 10 Feb 2025 11:28:29 +0530 [thread overview]
Message-ID: <9b18fa61-d689-46a5-9855-7f24d95094fc@intel.com> (raw)
In-Reply-To: <20250210061036.1228921-1-jeevan.b@intel.com>
LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
On 10-02-2025 11:40 am, Jeevan B wrote:
> extended mode test needs minimum 2 display to run, so add igt_require
> to check if the required criteria is met or not.
>
> v2: Fix commit message.
> v3: Update subject.
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
> tests/kms_display_modes.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
> index e41c60cc0..117f82325 100644
> --- a/tests/kms_display_modes.c
> +++ b/tests/kms_display_modes.c
> @@ -335,8 +335,10 @@ igt_main
> }
>
> igt_describe("Test for validating display extended mode with a pair of connected displays");
> - igt_subtest_with_dynamic("extended-mode-basic")
> + igt_subtest_with_dynamic("extended-mode-basic") {
> + igt_require_f(count > 1, "Minimum 2 outputs are required\n");
> run_extendedmode_test(&data);
> + }
>
> igt_describe("Negative test for validating display extended mode with a pair of connected "
> "2k-4k or 4k-4k displays");
next prev parent reply other threads:[~2025-02-10 5:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 6:10 [PATCH i-g-t] tests/kms_display_modes: Add check for ≥2 outputs in extended mode test Jeevan B
2025-02-10 5:58 ` Sharma, Swati2 [this message]
2025-02-10 8:43 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-02-10 8:55 ` ✓ i915.CI.BAT: " Patchwork
2025-02-10 10:17 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-10 14:59 ` B, Jeevan
2025-02-10 11:01 ` ✗ i915.CI.Full: " Patchwork
2025-02-10 14:59 ` B, Jeevan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b18fa61-d689-46a5-9855-7f24d95094fc@intel.com \
--to=swati2.sharma@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jeevan.b@intel.com \
--cc=pranay.samala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox