Re: [igt-dev] [PATCH i-g-t 5/6] tests/psr: Test PSR1 in kms_psr

[Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>]

On Tue, 2018-09-04 at 22:18 +0000, Souza, Jose wrote:
> On Wed, 2018-08-29 at 14:57 -0700, Dhinakaran Pandiyan wrote:
> > The tests we have work only with PSR1, but setting the module
> > parameter
> > enable_psr enables PSR2 if the panel supports it. Make use of the
> > newly
> > added debugfs toggle to enable only PSR1 when testing.
> 
> If the idea is latter have psr2_enable/disable then:

Yeah, that is the plan. Both psr_wait_for_entry() and psr_active()
aren't compatible with PSR2 as of now. We have to rewrite those
functions. Thanks for the reviews.

> 
> Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
> 
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > ---
> >  tests/kms_psr.c | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tests/kms_psr.c b/tests/kms_psr.c
> > index 3e64cf04..fcc04770 100644
> > --- a/tests/kms_psr.c
> > +++ b/tests/kms_psr.c
> > @@ -414,8 +414,9 @@ int main(int argc, char *argv[])
> >  		kmstest_set_vt_graphics_mode();
> >  		data.devid = intel_get_drm_devid(data.drm_fd);
> >  
> > -		igt_set_module_param_int("enable_psr",
> > data.with_psr_disabled ?
> > -					 0 : 1);
> > +		if (!data.with_psr_disabled)
> > +			psr_enable(data.debugfs_fd);
> > +
> >  		igt_require_f(sink_support(&data),
> >  			      "Sink does not support PSR\n");
> >  
> > @@ -490,6 +491,9 @@ int main(int argc, char *argv[])
> >  	}
> >  
> >  	igt_fixture {
> > +		if (!data.with_psr_disabled)
> > +			psr_disable(data.debugfs_fd);
> > +
> >  		close(data.debugfs_fd);
> >  		drm_intel_bufmgr_destroy(data.bufmgr);
> >  		display_fini(&data);
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev