public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Laguna, Lukasz" <lukasz.laguna@intel.com>
To: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>,
	<igt-dev@lists.freedesktop.org>
Cc: "Jakub Kolakowski" <jakub1.kolakowski@intel.com>,
	"Piotr Piórkowski" <piotr.piorkowski@intel.com>
Subject: Re: [PATCH v3 i-g-t 6/7] tests/intel/xe_sriov_flr: Add --no-xe-vfio-pci option
Date: Mon, 9 Feb 2026 11:18:36 +0100	[thread overview]
Message-ID: <9b5ba33f-aef1-4519-9bb5-0d542dc92312@intel.com> (raw)
In-Reply-To: <20260204163217.121305-7-marcin.bernatowicz@linux.intel.com>


On 2/4/2026 17:32, Marcin Bernatowicz wrote:
> Add --no-xe-vfio-pci to skip loading/binding VFs to xe-vfio-pci.
>
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
> Cc: Jakub Kolakowski <jakub1.kolakowski@intel.com>
> Cc: Lukasz Laguna <lukasz.laguna@intel.com>

Reviewed-by: Lukasz Laguna <lukasz.laguna@intel.com>

> Cc: Piotr Piórkowski <piotr.piorkowski@intel.com>
> ---
>   tests/intel/xe_sriov_flr.c | 13 +++++++++++--
>   1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel/xe_sriov_flr.c b/tests/intel/xe_sriov_flr.c
> index 951628159..b73727787 100644
> --- a/tests/intel/xe_sriov_flr.c
> +++ b/tests/intel/xe_sriov_flr.c
> @@ -63,6 +63,7 @@ static const char STOP_REASON_SKIP[]  = "SKIP";
>   #define DRIVER_OVERRIDE_TIMEOUT_MS 200
>   
>   static int g_wait_flr_ms = 200;
> +static bool g_use_xe_vfio_pci = true;
>   
>   static struct g_mmio {
>   	struct xe_mmio *mmio;
> @@ -385,7 +386,9 @@ static void verify_flr(int pf_fd, int num_vfs, struct subcheck *checks,
>   	if (igt_warn_on(igt_pci_system_reinit()))
>   		goto disable_vfs;
>   
> -	xe_vfio_loaded = igt_kmod_load("xe_vfio_pci", NULL) >= 0;
> +	xe_vfio_loaded = false;
> +	if (g_use_xe_vfio_pci)
> +		xe_vfio_loaded = igt_kmod_load("xe_vfio_pci", NULL) >= 0;
>   	if (xe_vfio_loaded) {
>   		vf_bound = calloc(num_vfs + 1, sizeof(*vf_bound));
>   		igt_assert(vf_bound);
> @@ -1097,6 +1100,10 @@ static int opt_handler(int opt, int opt_index, void *data)
>   	long val;
>   
>   	switch (opt) {
> +	case 'v':
> +		g_use_xe_vfio_pci = false;
> +		igt_info("xe-vfio-pci binding: disabled\n");
> +		break;
>   	case 'w':
>   		errno = 0;
>   		val = strtol(optarg, &end, 0);
> @@ -1113,14 +1120,16 @@ static int opt_handler(int opt, int opt_index, void *data)
>   }
>   
>   static const struct option long_options[] = {
> +	{ .name = "no-xe-vfio-pci", .has_arg = false, .val = 'v', },
>   	{ .name = "wait-flr-ms", .has_arg = true, .val = 'w', },
>   	{},
>   };
>   
>   static const char help_str[] =
> +	"  --no-xe-vfio-pci\tDo not load/bind xe-vfio-pci for VFs\n"
>   	"  --wait-flr-ms=MS\tSleep MS milliseconds after VF reset sysfs write (default: 200)\n";
>   
> -int igt_main_args("w:", long_options, help_str, opt_handler, NULL)
> +int igt_main_args("vw:", long_options, help_str, opt_handler, NULL)
>   {
>   	int pf_fd;
>   	bool autoprobe;

  reply	other threads:[~2026-02-09 10:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 16:32 [PATCH v3 i-g-t 0/7] PCI driver helpers and xe-vfio-pci FLR improvement Marcin Bernatowicz
2026-02-04 16:32 ` [PATCH v3 i-g-t 1/7] lib/igt_sriov_device: Add helper to get VF PCI slot address Marcin Bernatowicz
2026-02-04 16:32 ` [PATCH v3 i-g-t 2/7] lib/igt_pci: Add generic PCI driver override and bind/unbind helpers Marcin Bernatowicz
2026-02-09 10:16   ` Laguna, Lukasz
2026-02-10 10:19     ` Bernatowicz, Marcin
2026-02-11  6:39       ` Laguna, Lukasz
2026-02-11 11:21         ` Bernatowicz, Marcin
2026-02-04 16:32 ` [PATCH v3 i-g-t 3/7] tests/intel/xe_sriov_flr: Attach VFs to xe-vfio-pci before initiating FLR Marcin Bernatowicz
2026-02-09 10:17   ` Laguna, Lukasz
2026-02-04 16:32 ` [PATCH v3 i-g-t 4/7] lib/igt_kmod: Fix PCI bind/unbind for module/driver name mismatch Marcin Bernatowicz
2026-02-04 16:32 ` [PATCH v3 i-g-t 5/7] tests/intel/xe_sriov_flr: Add --wait-flr-ms option Marcin Bernatowicz
2026-02-09 10:18   ` Laguna, Lukasz
2026-02-04 16:32 ` [PATCH v3 i-g-t 6/7] tests/intel/xe_sriov_flr: Add --no-xe-vfio-pci option Marcin Bernatowicz
2026-02-09 10:18   ` Laguna, Lukasz [this message]
2026-02-04 16:32 ` [PATCH v3 i-g-t 7/7] tests/intel/xe_sriov_flr: Skip xe-vfio-pci load/bind when IOMMU is off Marcin Bernatowicz
2026-02-09 10:42   ` Laguna, Lukasz
2026-02-10 11:23     ` Bernatowicz, Marcin
2026-02-11  6:43       ` Laguna, Lukasz
2026-02-04 18:27 ` ✓ Xe.CI.BAT: success for PCI driver helpers and xe-vfio-pci FLR improvement (rev3) Patchwork
2026-02-04 18:41 ` ✓ i915.CI.BAT: " Patchwork
2026-02-05  5:02 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-05 10:13   ` Bernatowicz, Marcin
2026-02-05  8:13 ` ✓ i915.CI.Full: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b5ba33f-aef1-4519-9bb5-0d542dc92312@intel.com \
    --to=lukasz.laguna@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jakub1.kolakowski@intel.com \
    --cc=marcin.bernatowicz@linux.intel.com \
    --cc=piotr.piorkowski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox