From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20180221121012.27097-1-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Message-ID: <9bab7f84-dcbb-9dda-4a61-8428024dc84f@linux.intel.com> Date: Wed, 21 Feb 2018 13:00:33 +0000 MIME-Version: 1.0 In-Reply-To: <20180221121012.27097-1-chris@chris-wilson.co.uk> Content-Language: en-GB Subject: Re: [igt-dev] [PATCH igt v3] igt/perf_pmu: Use a self-correcting busy pwm List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org, Tvrtko Ursulin List-ID: Ck9uIDIxLzAyLzIwMTggMTI6MTAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBDb252ZXJ0IHRoZSBi dXN5IHB3bSBmcm9tIHVzaW5nIGEgc2luZ2xlIGNhbGlicmF0aW9uIHBhc3Mgd2l0aCBhIGZpeGVk Cj4gdGFyZ2V0IGludG8gYSBzZWxmLWNvcnJlY3RpbmcgcHdtIHRoYXQgdHJpZXMgdG8gYWRqdXN0 IGhvdyBsb25nIHRvIHNsZWVwCj4gb24gZWFjaCBwd20gaW4gb3JkZXIgdG8gY29udmVyZ2UgYXQg dGhlIHRhcmdldCBidXN5ICUlLgo+IAo+IEJlaW5nIHNlbGYtY29ycmVjdGluZywgaXQgc2hvdWxk IGZhcmUgYmV0dGVyIGFnYWluc3QgdGhlIG1vcmUgdmFyaWFibGUKPiBzeXN0ZW1zIENJIHByZXNl bnRzLgo+IAo+IHYyOiBCZSBmYWlyIGFuZCBlcXVhbGx5IHN0cmljdCBmb3IgbG93L2hpZ2ggYnVz eSAlJQo+IHYzOiB0YXJnZXRfaWRsZV91cyBhbmQgY2FsY3VsYXRlIGV4cGVjdGVkIGZyb20gdGlt aW5nIG9mIGVhY2ggaW5kaXZpZHVhbCBwYXNzCj4gCj4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5m cmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTE1Nwo+IFNpZ25lZC1vZmYtYnk6IENo cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0a28gVXJzdWxp biA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IC0tLQo+ICAgdGVzdHMvcGVyZl9wbXUuYyB8 IDc0ICsrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgNDAgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL3Rlc3RzL3BlcmZfcG11LmMgYi90ZXN0cy9wZXJmX3BtdS5jCj4g aW5kZXggN2ZhYjczZTIuLjk4ZDhkYmZmIDEwMDY0NAo+IC0tLSBhL3Rlc3RzL3BlcmZfcG11LmMK PiArKysgYi90ZXN0cy9wZXJmX3BtdS5jCj4gQEAgLTE0MjIsOSArMTQyMiwxMCBAQCBhY2N1cmFj eShpbnQgZ2VtX2ZkLCBjb25zdCBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIgKmUsCj4g ICAJCQkJYnVzeV91cyAvIDEwMCkgLyB0YXJnZXRfYnVzeV9wY3Q7Cj4gICAJdW5zaWduZWQgbG9u ZyBwd21fY2FsaWJyYXRpb25fdXM7Cj4gICAJdW5zaWduZWQgbG9uZyB0ZXN0X3VzOwo+IC0JZG91 YmxlIGJ1c3lfcjsKPiArCWRvdWJsZSBidXN5X3IsIGV4cGVjdGVkOwo+ICAgCXVpbnQ2NF90IHZh bFsyXTsKPiAgIAl1aW50NjRfdCB0c1syXTsKPiArCWludCBsaW5rWzJdOwo+ICAgCWludCBmZDsK PiAgIAo+ICAgCS8qIFNhbXBsaW5nIHBsYXRmb3JtcyBjYW5ub3QgcmVhY2ggdGhlIGhpZ2ggYWNj dXJhY3kgY3JpdGVyaWEuICovCj4gQEAgLTE0NTAsMTQgKzE0NTEsMTYgQEAgYWNjdXJhY3koaW50 IGdlbV9mZCwgY29uc3Qgc3RydWN0IGludGVsX2V4ZWN1dGlvbl9lbmdpbmUyICplLAo+ICAgCWFz c2VydF93aXRoaW5fZXBzaWxvbigoZG91YmxlKWJ1c3lfdXMgLyAoYnVzeV91cyArIGlkbGVfdXMp LAo+ICAgCQkJCShkb3VibGUpdGFyZ2V0X2J1c3lfcGN0IC8gMTAwLjAsIHRvbGVyYW5jZSk7Cj4g ICAKPiArCWlndF9hc3NlcnQocGlwZShsaW5rKSA9PSAwKTsKPiArCj4gICAJLyogRW1pdCBQV00g cGF0dGVybiBvbiB0aGUgZW5naW5lIGZyb20gYSBjaGlsZC4gKi8KPiAgIAlpZ3RfZm9yayhjaGls ZCwgMSkgewo+ICAgCQlzdHJ1Y3Qgc2NoZWRfcGFyYW0gcnQgPSB7IC5zY2hlZF9wcmlvcml0eSA9 IDk5IH07Cj4gLQkJY29uc3QgdW5zaWduZWQgbG9uZyB0aW1lb3V0W10gPSB7IHB3bV9jYWxpYnJh dGlvbl91cyAqIDEwMDAsCj4gLQkJCQkJCSAgdGVzdF91cyAqIDIgKiAxMDAwIH07Cj4gLQkJdW5z aWduZWQgbG9uZyBzbGVlcF9idXN5ID0gYnVzeV91czsKPiAtCQl1bnNpZ25lZCBsb25nIHNsZWVw X2lkbGUgPSBpZGxlX3VzOwo+ICsJCWNvbnN0IHVuc2lnbmVkIGxvbmcgdGltZW91dFtdID0gewo+ ICsJCQlwd21fY2FsaWJyYXRpb25fdXMgKiAxMDAwLCB0ZXN0X3VzICogMiAqIDEwMDAKPiArCQl9 Owo+ICAgCQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX2V4ZWNfb2JqZWN0MiBvYmogPSB7fTsKPiArCQl1 aW50NjRfdCB0b3RhbF9idXN5X25zID0gMCwgdG90YWxfaWRsZV9ucyA9IDA7Cj4gICAJCWlndF9z cGluX3QgKnNwaW47Cj4gICAJCWludCByZXQ7Cj4gICAKPiBAQCAtMTQ3OCw3NiArMTQ4MSw2NyBA QCBhY2N1cmFjeShpbnQgZ2VtX2ZkLCBjb25zdCBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2lu ZTIgKmUsCj4gICAKPiAgIAkJLyogMXN0IHBhc3MgaXMgY2FsaWJyYXRpb24sIHNlY29uZCBwYXNz IGlzIHRoZSB0ZXN0LiAqLwo+ICAgCQlmb3IgKGludCBwYXNzID0gMDsgcGFzcyA8IEFSUkFZX1NJ WkUodGltZW91dCk7IHBhc3MrKykgewo+IC0JCQl1bnNpZ25lZCBsb25nIGJ1c3lfbnMgPSAwLCBp ZGxlX25zID0gMDsKPiArCQkJdWludDY0X3QgYnVzeV9ucyA9IC10b3RhbF9idXN5X25zOwo+ICsJ CQl1aW50NjRfdCBpZGxlX25zID0gLXRvdGFsX2lkbGVfbnM7Cj4gICAJCQlzdHJ1Y3QgdGltZXNw ZWMgdGVzdF9zdGFydCA9IHsgfTsKPiAtCQkJdW5zaWduZWQgbG9uZyBsb29wcyA9IDA7Cj4gLQkJ CWRvdWJsZSBlcnJfYnVzeSwgZXJyX2lkbGU7Cj4gICAKPiAgIAkJCWlndF9uc2VjX2VsYXBzZWQo JnRlc3Rfc3RhcnQpOwo+ICAgCQkJZG8gewo+ICAgCQkJCXN0cnVjdCB0aW1lc3BlYyB0X2J1c3kg PSB7IH07Cj4gKwkJCQl1bnNpZ25lZCBpbnQgdGFyZ2V0X2lkbGVfdXM7Cj4gICAKPiAgIAkJCQlp Z3RfbnNlY19lbGFwc2VkKCZ0X2J1c3kpOwo+ICAgCj4gICAJCQkJLyogUmVzdGFydCB0aGUgc3Bp bmJhdGNoLiAqLwo+ICAgCQkJCV9fcmVhcm1fc3Bpbl9iYXRjaChzcGluKTsKPiAgIAkJCQlfX3N1 Ym1pdF9zcGluX2JhdGNoKGdlbV9mZCwgJm9iaiwgZSk7Cj4gLQkJCQltZWFzdXJlZF91c2xlZXAo c2xlZXBfYnVzeSk7Cj4gKwkJCQltZWFzdXJlZF91c2xlZXAoYnVzeV91cyk7Cj4gICAJCQkJaWd0 X3NwaW5fYmF0Y2hfZW5kKHNwaW4pOwo+ICAgCQkJCWdlbV9zeW5jKGdlbV9mZCwgb2JqLmhhbmRs ZSk7Cj4gICAKPiAtCQkJCWJ1c3lfbnMgKz0gaWd0X25zZWNfZWxhcHNlZCgmdF9idXN5KTsKPiAr CQkJCXRvdGFsX2J1c3lfbnMgKz0gaWd0X25zZWNfZWxhcHNlZCgmdF9idXN5KTsKPiAgIAo+IC0J CQkJaWRsZV9ucyArPSBtZWFzdXJlZF91c2xlZXAoc2xlZXBfaWRsZSk7Cj4gLQo+IC0JCQkJbG9v cHMrKzsKPiArCQkJCXRhcmdldF9pZGxlX3VzID0KPiArCQkJCQkoMTAwICogdG90YWxfYnVzeV9u cyAvIHRhcmdldF9idXN5X3BjdCAtICh0b3RhbF9idXN5X25zICsgdG90YWxfaWRsZV9ucykpIC8g MTAwMDsKPiArCQkJCXRvdGFsX2lkbGVfbnMgKz0gbWVhc3VyZWRfdXNsZWVwKHRhcmdldF9pZGxl X3VzKTsKPiAgIAkJCX0gd2hpbGUgKGlndF9uc2VjX2VsYXBzZWQoJnRlc3Rfc3RhcnQpIDwgdGlt ZW91dFtwYXNzXSk7Cj4gICAKPiAtCQkJYnVzeV9ucyA9IGRpdl9yb3VuZF91cChidXN5X25zLCBs b29wcyk7Cj4gLQkJCWlkbGVfbnMgPSBkaXZfcm91bmRfdXAoaWRsZV9ucywgbG9vcHMpOwo+IC0K PiAtCQkJZXJyX2J1c3kgPSBfX2Vycm9yKGJ1c3lfbnMgLyAxMDAwLCBidXN5X3VzKTsKPiAtCQkJ ZXJyX2lkbGUgPSBfX2Vycm9yKGlkbGVfbnMgLyAxMDAwLCBpZGxlX3VzKTsKPiAtCj4gLQkJCWln dF9pbmZvKCIldTogYnVzeSAlbHUvJWx1ICUuMmYlJSwgaWRsZSAlbHUvJWx1ICUuMmYlJVxuIiwK PiAtCQkJCSBwYXNzLAo+IC0JCQkJIGJ1c3lfbnMgLyAxMDAwLCBidXN5X3VzLCBlcnJfYnVzeSwK PiAtCQkJCSBpZGxlX25zIC8gMTAwMCwgaWRsZV91cywgZXJyX2lkbGUpOwo+IC0KPiAtCQkJaWYg KHBhc3MgPT0gMCkgewo+IC0JCQkJc2xlZXBfYnVzeSA9IChkb3VibGUpYnVzeV91cyAtCj4gLQkJ CQkJICAgICAoZG91YmxlKWJ1c3lfdXMgKiBlcnJfYnVzeSAvIDEwMC4wOwo+IC0JCQkJc2xlZXBf aWRsZSA9IChkb3VibGUpaWRsZV91cyAtCj4gLQkJCQkJICAgICAoZG91YmxlKWlkbGVfdXMgKiBl cnJfaWRsZSAvIDEwMC4wOwo+IC0JCQkJaWd0X2luZm8oImNhbGlicmF0ZWQgc2xlZXBzIHJhdGlv ICUuMmYlJSAoJWx1LyVsdSlcbiIsCj4gLQkJCQkJIChkb3VibGUpc2xlZXBfYnVzeSAvCj4gLQkJ CQkJIChzbGVlcF9idXN5ICsgc2xlZXBfaWRsZSkgKiAxMDAuMCwKPiAtCQkJCQkgc2xlZXBfYnVz eSwgc2xlZXBfaWRsZSk7Cj4gLQkJCX0KPiArCQkJYnVzeV9ucyArPSB0b3RhbF9idXN5X25zOwo+ ICsJCQlpZGxlX25zICs9IHRvdGFsX2lkbGVfbnM7Cj4gKwo+ICsJCQlleHBlY3RlZCA9IChkb3Vi bGUpYnVzeV9ucyAvIChidXN5X25zICsgaWRsZV9ucyk7Cj4gKwkJCWlndF9pbmZvKCIldTogYnVz eSAlbHV1cywgaWRsZSAlbHV1czogJS4yZiUlICh0YXJnZXQ6ICVsdSUlKVxuIiwKPiArCQkJCSBw YXNzLCBidXN5X25zIC8gMTAwMCwgaWRsZV9ucyAvIDEwMDAsCj4gKwkJCQkgMTAwICogZXhwZWN0 ZWQsIHRhcmdldF9idXN5X3BjdCk7Cj4gKwkJCXdyaXRlKGxpbmtbMV0sICZleHBlY3RlZCwgc2l6 ZW9mKGV4cGVjdGVkKSk7Cj4gICAJCX0KPiAgIAo+ICAgCQlpZ3Rfc3Bpbl9iYXRjaF9mcmVlKGdl bV9mZCwgc3Bpbik7Cj4gICAJfQo+ICAgCj4gICAJLyogTGV0IHRoZSBjaGlsZCBydW4uICovCj4g LQl1c2xlZXAocHdtX2NhbGlicmF0aW9uX3VzICogMik7Cj4gKwlyZWFkKGxpbmtbMF0sICZleHBl Y3RlZCwgc2l6ZW9mKGV4cGVjdGVkKSk7Cj4gKwlhc3NlcnRfd2l0aGluX2Vwc2lsb24oZXhwZWN0 ZWQsIHRhcmdldF9idXN5X3BjdC8xMDAuLCAwLjA1KTsKPiAgIAo+ICAgCS8qIENvbGxlY3QgZW5n aW5lIGJ1c3luZXNzIGZvciBhbiBpbnRlcmVzdGluZyBwYXJ0IG9mIGNoaWxkIHJ1bnRpbWUuICov Cj4gICAJZmQgPSBvcGVuX3BtdShJOTE1X1BNVV9FTkdJTkVfQlVTWShlLT5jbGFzcywgZS0+aW5z dGFuY2UpKTsKPiAgIAl2YWxbMF0gPSBfX3BtdV9yZWFkX3NpbmdsZShmZCwgJnRzWzBdKTsKPiAt CXVzbGVlcCh0ZXN0X3VzIC8gMik7Cj4gKwlyZWFkKGxpbmtbMF0sICZleHBlY3RlZCwgc2l6ZW9m KGV4cGVjdGVkKSk7Cj4gICAJdmFsWzFdID0gX19wbXVfcmVhZF9zaW5nbGUoZmQsICZ0c1sxXSk7 Cj4gICAJY2xvc2UoZmQpOwo+ICAgCj4gKwljbG9zZShsaW5rWzFdKTsKPiArCWNsb3NlKGxpbmtb MF0pOwo+ICsKPiAgIAlpZ3Rfd2FpdGNoaWxkcmVuKCk7Cj4gICAKPiAgIAlidXN5X3IgPSAoZG91 YmxlKSh2YWxbMV0gLSB2YWxbMF0pIC8gKHRzWzFdIC0gdHNbMF0pOwo+ICAgCj4gLQlpZ3RfaW5m bygiZXJyb3I9JS4yZiUlICglLjJmJSUgdnMgJWx1JSUpXG4iLAo+IC0JCSBfX2Vycm9yKGJ1c3lf ciwgdGFyZ2V0X2J1c3lfcGN0IC8gMTAwLjApLAo+IC0JCSBidXN5X3IgKiAxMDAuMCwgdGFyZ2V0 X2J1c3lfcGN0KTsKPiArCWlndF9pbmZvKCJlcnJvcj0lLjJmJSUgKCUuMmYlJSB2cyAlLjJmJSUp XG4iLAo+ICsJCSBfX2Vycm9yKGJ1c3lfciwgZXhwZWN0ZWQpLCAxMDAgKiBidXN5X3IsIDEwMCAq IGV4cGVjdGVkKTsKPiAgIAo+IC0JYXNzZXJ0X3dpdGhpbl9lcHNpbG9uKGJ1c3lfciwgKGRvdWJs ZSl0YXJnZXRfYnVzeV9wY3QgLyAxMDAuMCwgMC4xNSk7Cj4gKwlhc3NlcnRfd2l0aGluX2Vwc2ls b24oYnVzeV9yLCBleHBlY3RlZCwgMC4xNSk7Cj4gKwlhc3NlcnRfd2l0aGluX2Vwc2lsb24oMSAt IGJ1c3lfciwgMSAtIGV4cGVjdGVkLCAwLjE1KTsKPiAgIH0KPiAgIAo+ICAgaWd0X21haW4KPiAK ClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoK UmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK