From: "Hellstrom, Thomas" <thomas.hellstrom@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"Thomas, Sobin" <sobin.thomas@intel.com>
Cc: "Sharma, Nishit" <nishit.sharma@intel.com>
Subject: Re: [PATCH i-g-t 0/2] test/intel/xe_vm: Add overcommit and no‑overcommit handling tests
Date: Tue, 17 Feb 2026 14:06:23 +0000 [thread overview]
Message-ID: <9bdf7a77545331f568f81c123b55953cab079da7.camel@intel.com> (raw)
In-Reply-To: <8b1689e53c1e3b3ebe9810c86fc248a5040e52d0.camel@intel.com>
On Tue, 2026-02-17 at 14:57 +0100, Thomas Hellström wrote:
> Hi, Thomas,
>
> On Thu, 2026-02-12 at 19:03 +0000, Sobin Thomas wrote:
> > This series adds coverage to xe_vm test by adding over commit test
> > in
> > fault mode and
> > non fault mode.
> > Also added support to test the no overcommit flag
> > (DRM_XE_VM_CREATE_NO_VM_OVERCOMMIT)
> >
> > Sobin Thomas (2):
> > tests/intel/xe_vm: overcommit tests for fault-mode and non-fault-
> > mode
> > VMs
> > test/intel/xe_vm: Test to check no overcommit flag in fault mode
> >
> > include/drm-uapi/xe_drm.h | 1 +
> > tests/intel/xe_vm.c | 634
> > +++++++++++++++++++++++++++++++++++++-
> > 2 files changed, 630 insertions(+), 5 deletions(-)
>
> I wonder, is it possible to create a single test for the different
> modes and select the different modes with flags? The following should
> hold for bos in VRAM:
>
> 1. DRM_XE_VM_CREATE_FLAG_LR_MODE:
> a) If bos are created in VRAM only and either local to the VM or
> created with the flag DRM_XE_GEM_CREATE_FLAG_DEFER_BACKING, then
> overcommit is not allowed. Compute is relying on this and this is
> what
> "test_oom" tests.
> b) If bos are created external and without the flag
> DRM_XE_GEM_CREATE_FLAG_DEFER_BACKING, overcommit is allowed but will
> error on first exec.
>
> 2. DRM_XE_VM_CREATE_FLAG_LR_MODE | DRM_XE_VM_CREATE_FLAG_FAULT_MODE:
> Overcommit is always allowed. Should not error on exec.
>
> 3. !DRM_XE_VM_CREATE_FLAG_LR_MODE:
> Overcommit is always allowed. Should error on exec if overcommited.
>
> 4. DRM_XE_VM_CREATE_FLAG_LR_MODE | DRM_XE_VM_CREATE_FLAG_FAULT_MODE:
> DRM_XE_VM_CREATE_FLAG_NO_VM_OVERCOMMIT.
> Should behave just like 1.)
Except it should not fail on first exec.
>
> So it should be possible to create an array with VM create flags, bo
> create mode and expected results and use a single test?
>
> For bos in system memory the above should also hold but with the
> additional problem that it is likely that the oom killer is hit. In
> particular with systems without swap.
>
> Thanks,
> Thomas
>
>
prev parent reply other threads:[~2026-02-17 14:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 19:03 [PATCH i-g-t 0/2] test/intel/xe_vm: Add overcommit and no‑overcommit handling tests Sobin Thomas
2026-02-12 19:03 ` [PATCH i-g-t 1/2] tests/intel/xe_vm: overcommit tests for fault-mode and non-fault-mode VMs Sobin Thomas
2026-02-12 19:03 ` [PATCH i-g-t 2/2] test/intel/xe_vm: Test to check no overcommit flag in fault mode Sobin Thomas
2026-02-24 19:41 ` Kamil Konieczny
2026-02-12 21:19 ` ✗ Xe.CI.BAT: failure for test/intel/xe_vm: Add overcommit and no‑overcommit handling tests Patchwork
2026-02-12 21:37 ` ✓ i915.CI.BAT: success " Patchwork
2026-02-13 0:58 ` ✗ i915.CI.Full: failure " Patchwork
2026-02-13 23:52 ` ✗ Xe.CI.FULL: " Patchwork
2026-02-17 13:57 ` [PATCH i-g-t 0/2] " Hellstrom, Thomas
2026-02-17 14:06 ` Hellstrom, Thomas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bdf7a77545331f568f81c123b55953cab079da7.camel@intel.com \
--to=thomas.hellstrom@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=nishit.sharma@intel.com \
--cc=sobin.thomas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox