public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] igt: Remove incorrect get_aperture IOCTL arg
Date: Thu, 6 Dec 2018 13:34:33 -0800	[thread overview]
Message-ID: <9c0af76d-5578-ca68-d7ee-5b56ea880220@intel.com> (raw)
In-Reply-To: <154413136802.31489.14637963580638607346@skylake-alporthouse-com>



On 06/12/18 13:22, Chris Wilson wrote:
> Quoting Antonio Argenziano (2018-12-06 21:17:04)
>> The local implementation of struct drm_i915_gem_get_aperture is
>> inconsistent with what is defined in the driver and now made its way
>> into IGT's include folder. The correct structure also doesn't contain
>> fields that were being used is some require functions about stolen
>> size. Removed those functions and all tests that used the require, they
>> have been skipping for a while and if none complained they must not be
>> needed.
> 
> Or they are for future implementations...

I assumed they were for a proposed implementation that didn't land since 
gem_stolen has been there ~3yrs :)

Do you want to keep them? I'm OK with it but maybe we should add a 
comment saying there is a plan for extending the IOCTL.

Antonio

> -Chris
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2018-12-06 21:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06 21:17 [igt-dev] [PATCH i-g-t] igt: Remove incorrect get_aperture IOCTL arg Antonio Argenziano
2018-12-06 21:22 ` Chris Wilson
2018-12-06 21:34   ` Antonio Argenziano [this message]
2018-12-06 21:35 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c0af76d-5578-ca68-d7ee-5b56ea880220@intel.com \
    --to=antonio.argenziano@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tvrtko.ursulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox