Re: [PATCH i-g-t] tests/sriov_basic: Skip tests if sriov_totalvfs is zero

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 08.05.2024 21:32, Marcin Bernatowicz wrote:
> There is no point to run the tests if no VFs can be enabled.
> Additionally, the `for_random_sriov_num_vfs` macro will lead
> to undefined behavior if `sriov_totalvfs` is zero.
> 
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
> ---
>  tests/sriov_basic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/sriov_basic.c b/tests/sriov_basic.c
> index f58b3b7ba..1bc082d76 100644
> --- a/tests/sriov_basic.c
> +++ b/tests/sriov_basic.c
> @@ -120,7 +120,7 @@ igt_main
>  
>  	igt_fixture {
>  		pf_fd = drm_open_driver(DRIVER_ANY);
> -		igt_require(igt_sriov_is_pf(pf_fd));
> +		igt_require(igt_sriov_vfs_supported(pf_fd));

shouldn't the check for supported_vfs > 0 be a part of is_pf ?

IMO if a driver can't support any VF it's hard to name it a PF

>  		igt_require(igt_sriov_get_enabled_vfs(pf_fd) == 0);
>  		autoprobe = igt_sriov_is_driver_autoprobe_enabled(pf_fd);
>  	}