From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95ABB10E482 for ; Tue, 5 Dec 2023 08:05:01 +0000 (UTC) Message-ID: <9ecf0284-3f50-4c42-a8da-8e8001666cce@intel.com> Date: Tue, 5 Dec 2023 09:04:18 +0100 To: Michal Wajdeczko , References: <20231204171033.2167-1-lukasz.laguna@intel.com> <20231204171033.2167-6-lukasz.laguna@intel.com> Content-Language: pl From: "Laguna, Lukasz" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v6 5/8] tests/sriov_basic: add basic tests for enabling SR-IOV VFs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 12/4/2023 21:50, Michal Wajdeczko wrote: > > On 04.12.2023 18:10, Lukasz Laguna wrote: >> From: Katarzyna Dec >> >> Add subtests that validate SR-IOV VFs enabling in two variants: with >> autoprobe disabled and enabled. >> >> v2: >> - rename function (Michal) >> - remove checks that are outside the scope of the test (Michal) >> v3: >> - change run type of enable-vfs-autoprobe-on subtest (Michal) >> - don't init random seed in test code (Michal) >> >> Cc: Marcin Bernatowicz >> Cc: Michal Wajdeczko >> Signed-off-by: Katarzyna Dec >> Signed-off-by: Lukasz Laguna >> --- >> tests/meson.build | 1 + >> tests/sriov_basic.c | 123 ++++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 124 insertions(+) >> create mode 100644 tests/sriov_basic.c >> >> diff --git a/tests/meson.build b/tests/meson.build >> index facf60ccf..a6673c511 100644 >> --- a/tests/meson.build >> +++ b/tests/meson.build >> @@ -71,6 +71,7 @@ test_progs = [ >> 'panfrost_submit', >> 'prime_udl', >> 'prime_vgem', >> + 'sriov_basic', >> 'syncobj_basic', >> 'syncobj_eventfd', >> 'syncobj_wait', >> diff --git a/tests/sriov_basic.c b/tests/sriov_basic.c >> new file mode 100644 >> index 000000000..582e644f2 >> --- /dev/null >> +++ b/tests/sriov_basic.c >> @@ -0,0 +1,123 @@ >> +// SPDX-License-Identifier: MIT >> +/* >> + * Copyright(c) 2023 Intel Corporation. All rights reserved. >> + */ >> + >> +#include "drmtest.h" >> +#include "igt_core.h" >> +#include "igt_sriov_device.h" >> + >> +IGT_TEST_DESCRIPTION("Basic tests for enabling SR-IOV Virtual Functions"); >> + >> +/** >> + * TEST: sriov_basic >> + * Category: Software building block >> + * Mega feature: SR-IOV >> + * Sub-category: VFs enabling >> + * Description: Validate SR-IOV VFs enabling >> + */ >> + >> +/** >> + * SUBTEST: enable-vfs-autoprobe-off >> + * Description: >> + * Verify VFs enabling without probing VF driver >> + * Run type: BAT >> + */ >> +static void enable_vfs_autoprobe_off(int pf_fd, unsigned int num_vfs) >> +{ >> + igt_debug("Testing %u VFs\n", num_vfs); >> + >> + igt_require(igt_sriov_get_enabled_vfs(pf_fd) == 0); >> + igt_sriov_disable_driver_autoprobe(pf_fd); >> + igt_sriov_enable_vfs(pf_fd, num_vfs); >> + igt_assert_eq(num_vfs, igt_sriov_get_enabled_vfs(pf_fd)); >> + igt_sriov_disable_vfs(pf_fd); >> +} >> + >> +/** >> + * SUBTEST: enable-vfs-autoprobe-on >> + * Description: >> + * Verify VFs enabling and auto-probing VF driver >> + * Run type: FULL > can't we just have enable_vfs_bind_unbind_each() from 8/8 ? > > this test as-is is still from STRESS category, that I'm not sure we use > elsewhere, while enable_vfs_bind_unbind_each() will provide solid > functional coverage that we are looking for I'll remove enable_vfs_bind_unbind_each() as you sugested in 7/8, but I prefer to leave this one: - enabling 1 or 2 VFs with autoprobe enabled is not that stress and it's common scenario - if we remove this test we won't have any coverage where we try to probe VF driver while it's already probed on other VF - it's good to know how it behaves in more stress cases >> + */ >> +static void enable_vfs_autoprobe_on(int pf_fd, unsigned int num_vfs) >> +{ >> + bool err = false; >> + >> + igt_debug("Testing %u VFs\n", num_vfs); >> + >> + igt_require(igt_sriov_get_enabled_vfs(pf_fd) == 0); >> + igt_sriov_enable_driver_autoprobe(pf_fd); >> + igt_sriov_enable_vfs(pf_fd, num_vfs); >> + igt_assert_eq(num_vfs, igt_sriov_get_enabled_vfs(pf_fd)); >> + for (int vf_num = 1; vf_num <= num_vfs; ++vf_num) { >> + if (!igt_sriov_is_vf_drm_driver_probed(pf_fd, vf_num)) { >> + igt_debug("VF%u probe failed\n", vf_num); >> + err = true; >> + } >> + } >> + igt_sriov_disable_vfs(pf_fd); >> + igt_assert(!err); >> +} >> + >> +igt_main >> +{ >> + int pf_fd; >> + bool autoprobe; >> + >> + igt_fixture { >> + pf_fd = drm_open_driver(DRIVER_ANY); >> + igt_require(igt_sriov_is_pf(pf_fd)); >> + igt_require(igt_sriov_get_enabled_vfs(pf_fd) == 0); >> + autoprobe = igt_sriov_is_driver_autoprobe_enabled(pf_fd); >> + } >> + >> + igt_describe("Verify VFs enabling without probing VF driver"); >> + igt_subtest_with_dynamic("enable-vfs-autoprobe-off") { >> + for_each_sriov_num_vfs(pf_fd, num_vfs) { >> + igt_dynamic_f("numvfs-%u", num_vfs) { >> + enable_vfs_autoprobe_off(pf_fd, num_vfs); >> + } >> + } >> + for_random_sriov_num_vfs(pf_fd, num_vfs) { >> + igt_dynamic_f("numvfs-random") { >> + enable_vfs_autoprobe_off(pf_fd, num_vfs); >> + } >> + } >> + for_max_sriov_num_vfs(pf_fd, num_vfs) { >> + igt_dynamic_f("numvfs-all") { >> + enable_vfs_autoprobe_off(pf_fd, num_vfs); >> + } >> + } >> + } >> + >> + igt_describe("Verify VFs enabling and auto-probing VF driver"); >> + igt_subtest_with_dynamic("enable-vfs-autoprobe-on") { >> + for_each_sriov_num_vfs(pf_fd, num_vfs) { >> + igt_dynamic_f("numvfs-%u", num_vfs) { >> + enable_vfs_autoprobe_on(pf_fd, num_vfs); >> + } >> + } >> + for_random_sriov_num_vfs(pf_fd, num_vfs) { >> + igt_dynamic_f("numvfs-random") { >> + enable_vfs_autoprobe_on(pf_fd, num_vfs); >> + } >> + } >> + for_max_sriov_num_vfs(pf_fd, num_vfs) { >> + igt_dynamic_f("numvfs-all") { >> + enable_vfs_autoprobe_on(pf_fd, num_vfs); >> + } >> + } >> + } >> + >> + igt_fixture { >> + igt_sriov_disable_vfs(pf_fd); >> + /* abort to avoid execution of next tests with enabled VFs */ >> + igt_abort_on_f(igt_sriov_get_enabled_vfs(pf_fd) > 0, "Failed to disable VF(s)"); >> + autoprobe ? igt_sriov_enable_driver_autoprobe(pf_fd) : >> + igt_sriov_disable_driver_autoprobe(pf_fd); >> + igt_abort_on_f(autoprobe != igt_sriov_is_driver_autoprobe_enabled(pf_fd), >> + "Failed to restore sriov_drivers_autoprobe value\n"); >> + close(pf_fd); >> + } >> +}