From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2065.outbound.protection.outlook.com [40.107.100.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 609BA10E002 for ; Fri, 14 Jul 2023 09:24:51 +0000 (UTC) Message-ID: <9eea967b-52ea-03b4-295e-2fcdf945d33f@amd.com> Date: Fri, 14 Jul 2023 17:23:39 +0800 Content-Language: en-US To: Kamil Konieczny , igt-dev@lists.freedesktop.org, Harry.Wentland@amd.com, Lili.Gong@amd.com, Wayne.Lin@amd.com References: <20230705152606.13117-1-HaoPing.Liu@amd.com> <20230711175913.vdyn6zfgndquvnt2@kamilkon-desk1> From: "Liu, HaoPing (Alan)" In-Reply-To: <20230711175913.vdyn6zfgndquvnt2@kamilkon-desk1> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH v3 1/2] drm-uapi/drm_mode: sync with latest uAPI changes for checksum_region List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Hi Kamil, On 2023/7/12 上午 01:59, Kamil Konieczny wrote: > Hi Alan, > > On 2023-07-05 at 23:26:05 +0800, Alan Liu wrote: >> Add struct drm_checksum_region and struct drm_checksum_crc as the >> userspace data for using checksum_region feature. >> >> Signed-off-by: Alan Liu > Please send this as a separate patch, write also to which repo > are you sync-ing, is it drm-tip? I am trying to submit patches of checksum_region feature to dri-devel (https://patchwork.freedesktop.org/series/119499/). This patch series is the IGT for testing checksum_region, and this particular patch adds the structs in drm_mode.h for IGT userspace to test checksum_region. I think I've already collected all the changes to drm_mode.h into this patch. Do you want me to separate this patch into a new patch series? Thanks, Alan > Regards, > Kamil > >> --- >> include/drm-uapi/drm_mode.h | 42 +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> >> diff --git a/include/drm-uapi/drm_mode.h b/include/drm-uapi/drm_mode.h >> index e4a2570a6..dec073921 100644 >> --- a/include/drm-uapi/drm_mode.h >> +++ b/include/drm-uapi/drm_mode.h >> @@ -1209,6 +1209,48 @@ struct drm_mode_rect { >> __s32 y2; >> }; >> >> +/** >> + * struct drm_checksum_region - The enablement and region of checksum_region >> + * @x_start: Horizontal starting coordinate of the region. >> + * @y_start: Vertical starting coordinate of the region. >> + * @x_end: Horizontal ending coordinate of the region. >> + * @y_end: Vertical ending coordinate of the region. >> + * @checksum_region_enable: To enable or disable checksum_region. >> + * >> + * Userspace uses this structure to configure the region and enablement for >> + * checksum_region. Userspace should not submit a region out of the displayable >> + * region because there is nothing to display and need protection. >> + */ >> +struct drm_checksum_region { >> + __u32 x_start; >> + __u32 y_start; >> + __u32 x_end; >> + __u32 y_end; >> + __u8 checksum_region_enable; >> + __u8 pad[7]; >> +}; >> + >> +/** >> + * struct drm_checksum_crc - The CRC value of the corresponding checksum region. >> + * @crc_r: CRC value of red color. >> + * @crc_g: CRC value of green color. >> + * @crc_b: CRC value of blue color. >> + * @frame_count: a referenced frame count to indicate which frame the CRC values >> + * are generated at. >> + * >> + * Userspace uses this structure to retrieve the CRC values of the current >> + * checksum region. @frame_count will be reset once a new region is updated or >> + * it reaches a maximum value. Currently these CRC values are designed to >> + * be validated with pre-saved CRC values, so userspace doesn't need to concern >> + * about the algorithm used to compute the CRC. >> + */ >> +struct drm_checksum_crc { >> + __u32 crc_r; >> + __u32 crc_g; >> + __u32 crc_b; >> + __u32 frame_count; >> +}; >> + >> #if defined(__cplusplus) >> } >> #endif >> -- >> 2.34.1 >>