Re: [igt-dev] [PATCH] tests/intel-ci/xe.blocklist: Add discarded tests in blocklist

["Joshi, Kunal1" <kunal1.joshi@intel.com>]

On 7/13/2023 5:23 PM, Kamil Konieczny wrote:
> Hi Kunal,
>
> small nit regarding subject:
>
> [PATCH] tests/intel-ci/xe.blocklist: Add discarded tests in blocklist
> ------------------------- ^ ------------------------------- ^
>
> You already have 'blocklist' there, no need for repeatition, also
> below you wrote about "not present" ones, so maybe:
>
> [PATCH] tests/intel-ci/xe.blocklist: Add not present tests
>
> On 2023-07-13 at 12:47:57 +0530, Kunal Joshi wrote:
>> Chamelium and PSR config is not present on XE bat as of now
>> and hang tests are yet to be enabled hence added them in blocklist
> --------------------------------------------------------------------^
> Put dot "." at end of sentence.
>
>> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
>> ---
>>   tests/intel-ci/xe.blocklist.txt | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/tests/intel-ci/xe.blocklist.txt b/tests/intel-ci/xe.blocklist.txt
>> index 02edeb6b6..43bd360a8 100644
>> --- a/tests/intel-ci/xe.blocklist.txt
>> +++ b/tests/intel-ci/xe.blocklist.txt
>> @@ -82,3 +82,11 @@ igt@kms_plane_lowres@tiling-(4|x|y|yf)
>>   ##################################################################
>>   igt@xe_sysfs*
>>   ##################################################################
>> +# No chamelium/psr setup on XE bat
>> +##################################################################
>> +igt@.*chamelium.*
>> +igt@.*psr.*
>> +##################################################################
>> +# Hang tests not yet enabled
>> +##################################################################
>> +igt@kms_pipe_crc_basic@hang-read-crc
> Why only this one? Maybe it should be:
> igt@kms_.*@.*hang.*
>
> Regards,
> Kamil
>
>> -- 
>> 2.25.1

Thanks Kamil for pointing, have sent next revision with comments addressed

Thanks and Regards
Kunal Joshi