Re: [PATCH i-g-t] tests/kms_cursor_legacy: Prefer tile4 modifier when supported

["Naladala, Ramanaidu" <Ramanaidu.naladala@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1451 bytes --]

Hi Jeevan,

On 3/16/2026 9:08 AM, Jeevan B wrote:
> While creating the framebuffer, prefer tile4 when it is supported
> instead of always using linear. Fall back to linear if tile4 is not
> available.
>
> Signed-off-by: Jeevan B<jeevan.b@intel.com>
> ---
>   tests/kms_cursor_legacy.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> index 5399ef481..4c4e477a1 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -367,15 +367,21 @@ static void set_fb_on_crtc(igt_display_t *display, igt_crtc_t *crtc,
>   {
>   	drmModeModeInfoPtr mode;
>   	igt_plane_t *primary;
> +	uint64_t modifier = DRM_FORMAT_MOD_LINEAR;
>   
>   	igt_output_set_crtc(output, crtc);
>   	mode = igt_output_get_mode(output);
>   
> +	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> +
> +	if (igt_plane_has_format_mod(primary, DRM_FORMAT_XRGB8888,
> +				     I915_FORMAT_MOD_4_TILED))
> +		modifier = I915_FORMAT_MOD_4_TILED;
> +
>   	igt_create_pattern_fb(display->drm_fd,
>   		      mode->hdisplay, mode->vdisplay,
> -		      DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, fb_info);
> +		      DRM_FORMAT_XRGB8888, modifier, fb_info);
>   
> -	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
>   	igt_plane_set_fb(primary, fb_info);
>   }

LGTM,

Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>

>   

[-- Attachment #2: Type: text/html, Size: 2095 bytes --]