Re: [PATCH i-g-t 2/2] tests/intel/kms_dsc: Split max_bpc constraint

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Pranay,

On 02-12-2024 04:40 pm, Samala, Pranay wrote:
> Hi Swati,
>
>> -----Original Message-----
>> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Swati
>> Sharma
>> Sent: Monday, December 2, 2024 2:21 PM
>> To: igt-dev@lists.freedesktop.org
>> Cc: Sharma, Swati2 <swati2.sharma@intel.com>
>> Subject: [PATCH i-g-t 2/2] tests/intel/kms_dsc: Split max_bpc constraint
>>
>> Split max_bpc constraint and add igt_info message.
>>
>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>> ---
>>   tests/intel/kms_dsc.c | 8 ++++++--
>>   1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/intel/kms_dsc.c b/tests/intel/kms_dsc.c index
>> 9b48caf76..5508e7a9e 100644
>> --- a/tests/intel/kms_dsc.c
>> +++ b/tests/intel/kms_dsc.c
>> @@ -281,10 +281,14 @@ static void test_dsc(data_t *data, uint32_t test_type,
>> int bpc,
>>   		data->pipe = pipe;
>>
>>   		if (!is_dsc_supported_by_sink(data->drm_fd, data->output) ||
>> -		    !check_gen11_dp_constraint(data->drm_fd, data->output,
>> data->pipe) ||
>> -		     igt_get_output_max_bpc(data->drm_fd, output->name) <
>> MIN_DSC_BPC)
>> +		    !check_gen11_dp_constraint(data->drm_fd, data->output,
>> +data->pipe))
>>   			continue;
>>
>> +		if (igt_get_output_max_bpc(data->drm_fd, output->name) <
>> MIN_DSC_BPC) {
>> +			igt_info("Output %s doesn't support min %d-bpc\n",
>> igt_output_name(data->output), MIN_DSC_BPC);
> line length is 119 columns, exceeding 100 columns.
This has been before, didn't make any change. May be we can have cleanup 
patch later.
>> +			continue;
>> +		}
>> +
>>   		if ((test_type & TEST_DSC_OUTPUT_FORMAT) &&
>>   		    (!is_dsc_output_format_supported(data->drm_fd, data-
>>> disp_ver,
>>   						     data->output, data-
>>> output_format)))
> Apart from this code looks good to me.
>
> Regards,
> Pranay Samala
>> --
>> 2.25.1