Re: [PATCH i-g-t v4 1/2] lib/igt_chamelium: Add igt_chamelium_get_port() helper and connector_test() macro

[Sebastian Brzezinka <sebastian.brzezinka@intel.com>]

Hi Mohammed,

On Mon Dec 15, 2025 at 4:07 PM CET, Mohammed Bilal wrote:
> Add a helper to retrieve the first matching Chamelium port and introduce
> a connector_test macro to streamline connector-based subtests with
> automatic lookup and clean skipping.
>
> Signed-off-by: Mohammed Bilal <mohammed.bilal@intel.com>
> ---
>  lib/igt_chamelium.c | 22 ++++++++++++++++++++++
>  lib/igt_chamelium.h | 26 ++++++++++++++++++++++++++
>  2 files changed, 48 insertions(+)
>
> diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
> index cb240a7df..95fd9dd4b 100644
> --- a/lib/igt_chamelium.c
> +++ b/lib/igt_chamelium.c
> @@ -3260,6 +3260,28 @@ bool chamelium_wait_all_configured_ports_connected(struct chamelium *chamelium,
>  	return wait_for_connected_state(drm_fd, connectors, connectors_count);
>  }
>  
> +/**
> + * igt_chamelium_get_port - Locate the first port matching a connector type
> + *
> + * Finds and returns the first Chamelium port that matches the requested
> + * connector type. Iterates through the provided port list and compares
> + * each port’s connector type. Returns NULL when no matching port exists.
> + */
> +
> +struct chamelium_port *
> +igt_chamelium_get_port(struct chamelium_port **ports,
> +		       int port_count, int connector_type)
> +{
> +	int i;
> +
> +	for (i = 0; i < port_count; i++) {
> +		if (chamelium_port_get_type(ports[i]) == connector_type)
> +			return ports[i];
> +	}
> +
> +	return NULL;
> +}
> +
>  igt_constructor {
>  	/* Frame dumps can be large, so we need to be able to handle very large
>  	 * responses
> diff --git a/lib/igt_chamelium.h b/lib/igt_chamelium.h
> index b5d13ddc8..2733e3a11 100644
> --- a/lib/igt_chamelium.h
> +++ b/lib/igt_chamelium.h
> @@ -274,4 +274,30 @@ bool chamelium_plug_all(struct chamelium *chamelium);
>  bool chamelium_wait_all_configured_ports_connected(struct chamelium *chamelium,
>  						   int drm_fd);
>  
> +struct chamelium_port *igt_chamelium_get_port(struct chamelium_port **ports,
> +					      int port_count, int connector_type);
> +
> +/**
> + * connector_test() - Run a subtest bound to a specific connector type
> + *
> + * This macro wraps a subtest and automatically resolves the required
> + * Chamelium port using igt_chamelium_get_port(). If the requested
> + * connector type is not present, the subtest is skipped cleanly.
> + *
> + * Helps avoid repeated connector-lookup logic and provides a uniform
> + * pattern for connector-specific subtests.
> + */
> +
> +#define connector_test(name, connector_type, test_fn, ...)				\
> +	do {										\
> +		igt_subtest(name) {							\
> +			struct chamelium_port *port =					\
> +				igt_chamelium_get_port(data.ports, data.port_count,	\
> +					DRM_MODE_CONNECTOR_##connector_type);		\
> +			if (!port)							\
> +				igt_skip(#connector_type " connector not available\n");	\
> +			test_fn(&data, port, ##__VA_ARGS__);				\
> +		}									\
> +	} while (0)
> +
>  #endif /* IGT_CHAMELIUM_H */
Overal, looks good to me. 
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>

-- 
Best regards,
Sebastian