Re: [PATCH i-g-t v7 3/3] tests/chamelium: Rename connector_test to connector_subtest

[Sebastian Brzezinka <sebastian.brzezinka@intel.com>]

Hi Mohammed,

On Tue Feb 3, 2026 at 4:45 AM CET, Mohammed Bilal wrote:
> Remove the old connector_subtest macro and rename connector_test to
> connector_subtest everywhere, consolidating on a single macro name
> while keeping the improved implementation that properly handles
> connector iteration and skipping.
>
> Signed-off-by: Mohammed Bilal <mohammed.bilal@intel.com>
> ---
>  tests/chamelium/kms_chamelium_audio.c  | 16 ++---
>  tests/chamelium/kms_chamelium_edid.c   | 64 +++++++++--------
>  tests/chamelium/kms_chamelium_frames.c | 42 +++++------
>  tests/chamelium/kms_chamelium_helper.h |  9 +--
>  tests/chamelium/kms_chamelium_hpd.c    | 99 +++++++++++++-------------
>  5 files changed, 114 insertions(+), 116 deletions(-)
>
> diff --git a/tests/chamelium/kms_chamelium_audio.c b/tests/chamelium/kms_chamelium_audio.c
> index 030a01051..df8d27c0c 100644
> --- a/tests/chamelium/kms_chamelium_audio.c
> +++ b/tests/chamelium/kms_chamelium_audio.c
> @@ -859,22 +859,22 @@ int igt_main()
>  	igt_describe("DisplayPort tests");
>  
>  	igt_describe(test_display_audio_desc);
> -	connector_test("dp-audio", DisplayPort, &data, test_display_audio,
> -		       "HDMI", IGT_CUSTOM_EDID_DP_AUDIO);
> +	connector_subtest("dp-audio", DisplayPort, &data, test_display_audio,
The series currently adds connector_test() and then renames it back to
connector_subtest() in a later patch. This extra step makes the history
harder to read.  Please consider introducing the new helper directly as
connector_subtest() and dropping the temporary rename.

-- 
Best regards,
Sebastian