Re: [PATCH v3 i-g-t 1/4] tools/meson: make per-tool dependencies instead of using global deps

[Sebastian Brzezinka <sebastian.brzezinka@intel.com>]

On Thu Feb 26, 2026 at 5:30 PM CET, Kamil Konieczny wrote:
> Hi Sebastian,
> On 2026-02-19 at 15:14:50 +0100, Sebastian Brzezinka wrote:
>> Rework tools/meson.build to stop linking every tool against the full
>> global igt_deps set. Most tools do not require cairo, glib, udev,
>> pciaccess, or zlib, and the previous all‑tools‑get‑everything approach
>> pulled in unnecessary libraries.
>> 
>> Introduce a small shared base dependency set (lib_igt, libdrm) and
>> switch to a per‑tool dependency dictionary. Tools now declare their
>> actual extra requirements explicitly, reducing over‑linking and making
>> dependency intent clearer.
>> 
>> Fold previously standalone tool definitions into the unified tools_progs
>> structure and use consistent executable() creation. The tools list is
>> also reordered to keep it clean and logically grouped.
>> 
>> This is a build‑system cleanup only; no functional behavior changes.
>> 
>> Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
>> ---
>>  tools/meson.build | 121 ++++++++++++++++++++++------------------------
>>  1 file changed, 57 insertions(+), 64 deletions(-)
>
> There is much work done with little gain and one regression.
Thanks for taking the time to run the comparison and share the results.
I’m aware that most of the changes in this series are focused on
improving clarity and structure rather than altering dependencies
themselves. The intent was mainly to make the tools dependency
requirements explicit and avoid the situation where every new library
ends up being linked by all tools.

> I used following script script:
>
> #!/bin/sh
> # SPDX-License-Identifier: MIT
>
> # compile igt source with changes in 'new' folder
> # keep non-modified compilation in 'old' folder
>
> cd new
> find build/tools/ -maxdepth 1 -type f | while read line; do
>         nnew=$(ldd $line |wc -l)
>         nold=$(ldd ../old/$line |wc -l)
>         echo $nnew $nold $line
> done
> cd ..
>
> From output there are two tools with changes, regression:
>
> 10 7 build/tools/intel_gpu_top
Regarding the regression in intel_gpu_top, the additional dependencies
(libpcre2 and libglib‑2.0) come indirectly through lib/igt_tools_stub.c,
so that part is understood.

>
> improvement:
>
> 10 79 build/tools/lsgpu
>
> Can you create lsgpu linking like one done for intel_gpu_top
> and work on more improvements in this series?
I’m currently working on improving the series further. I’ll take a
closer look at lsgpu and see how much of the minimal linking approach
used for intel_gpu_top can be applied there as well. It may not be
entirely straightforward, but I’ll try to reduce the dependencies as
much as possible.

Thanks again for th feedback
-- 
Best regards,
Sebastian