Re: [PATCH] tools/igt_power: Fix crash on Xe devices by initializing xe_device cache

[Sebastian Brzezinka <sebastian.brzezinka@intel.com>]

Hi,

On Tue May 19, 2026 at 1:28 PM CEST, Kamil Konieczny wrote:
> Hi Sebastian,
> On 2026-05-18 at 14:32:24 +0200, Sebastian Brzezinka wrote:
>> Opening a DRM device with plain open() does not initialize the Xe device
>> cache. When igt_power_open() calls is_intel_dgfx() -> xe_has_vram(), it
>> uses find_in_cache() which asserts the cache entry exists, causing a crash
>> on Xe devices with: xe_query-CRITICAL: Failed assertion: xe_dev
>> 
>> Fix this by opening the device with O_RDWR (required for DRM ioctls),
>> calling xe_device_get() for Xe devices to populate the cache before
>> calling igt_power_open(), and calling xe_device_put() on cleanup for
>> proper cache management.
>> 
>> Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
>> ---
>>  tools/igt_power.c | 18 +++++++++++++++---
>>  1 file changed, 15 insertions(+), 3 deletions(-)
>> 
>> diff --git a/tools/igt_power.c b/tools/igt_power.c
>> index 6dd180d34..11da0430b 100644
>> --- a/tools/igt_power.c
>> +++ b/tools/igt_power.c
>> @@ -11,6 +11,7 @@
>>  
>>  #include "drmtest.h"
>>  #include "igt_power.h"
>> +#include "xe/xe_query.h"
>>  
>
> While you fix it now, your change make it even more difficult
> to remove 'testing' dependancy in tools, see work item
> https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/work_items/16
> IGT command line tools load redundant GUI libraries
Yeah, I know. I can probably handle it in igt_power_open(), but I’m
not sure it helps much with the dependency issue overall.  Still, it
should be a bit cleaner, so I’ll go with v2.

-- 
Best regards,
Sebastian