Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
To: Krzysztof Karas <krzysztof.karas@intel.com>,
	<igt-dev@lists.freedesktop.org>
Cc: Andi Shyti <andi.shyti@linux.intel.com>,
	Sebastian Brzezinka <sebastian.brzezinka@intel.com>,
	Krzysztof Niemiec <krzysztof.niemiec@intel.com>,
	Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Subject: Re: [PATCH i-g-t] tests/intel: Add current IGT PID to driver options
Date: Mon, 1 Jun 2026 13:04:08 +0200	[thread overview]
Message-ID: <DIXNVODLU6P4.1NBSJFQ90R8CZ@intel.com> (raw)
In-Reply-To: <20260528055957.2876648-1-krzysztof.karas@intel.com>

Hi Krszysztof,

On Thu May 28, 2026 at 7:59 AM CEST, Krzysztof Karas wrote:
> i915 mmap selftests lack trusted address space in userspace,
> so use a driver parameter to pass IGT process's PID to borrow
> memory from for mapping. This will help to restore test
> coverage, which was temporarily limited when following series
> on kernel side was merged:
> e8c3344765aa ("drm/i915/selftests: Prevent userspace mapping invalidation")
> 82eb94b1fa13 ("drm/i915/selftests: Run vma tests only if current->mm is present")
>
> Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
> ---
>  tests/intel/i915_selftest.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel/i915_selftest.c b/tests/intel/i915_selftest.c
> index 6972de64c..1a8385883 100644
> --- a/tests/intel/i915_selftest.c
> +++ b/tests/intel/i915_selftest.c
> @@ -649,8 +649,8 @@ int igt_main()
>  	igt_kselftests("i915", opts, NULL, "mock", NULL);
>  
>  	igt_assert(snprintf(opts, sizeof(opts),
> -			    "live_selftests=-1 disable_display=1 st_filter=%s",
> -			    env) < sizeof(opts));
> +			    "live_selftests=-1 disable_display=1 st_filter=%s st_userspace_pid=%d",
> +			    env, getpid()) < sizeof(opts));
>  	igt_kselftests("i915", opts, "live_selftests", "live", NULL);
>  
>  	igt_assert(snprintf(opts, sizeof(opts),
LGTM
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>


-- 
Best regards,
Sebastian


  parent reply	other threads:[~2026-06-01 11:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-28  5:59 [PATCH i-g-t] tests/intel: Add current IGT PID to driver options Krzysztof Karas
2026-05-28  7:32 ` ✗ i915.CI.BAT: failure for tests/intel: Add current IGT PID to driver options (rev2) Patchwork
2026-06-01  6:05   ` Krzysztof Karas
2026-05-28  7:33 ` ✓ Xe.CI.BAT: success " Patchwork
2026-05-28 15:05 ` ✓ Xe.CI.FULL: " Patchwork
2026-06-01 11:04 ` Sebastian Brzezinka [this message]
2026-06-01 12:15 ` [PATCH i-g-t] tests/intel: Add current IGT PID to driver options Janusz Krzysztofik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DIXNVODLU6P4.1NBSJFQ90R8CZ@intel.com \
    --to=sebastian.brzezinka@intel.com \
    --cc=andi.shyti@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=janusz.krzysztofik@linux.intel.com \
    --cc=krzysztof.karas@intel.com \
    --cc=krzysztof.niemiec@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox