Re: [PATCH i-g-t 2/3] tests/gpu_buddy: Update buddy allocator tests

[Sebastian Brzezinka <sebastian.brzezinka@intel.com>]

Hi Krzysztof,

On Tue Jun 23, 2026 at 10:01 PM CEST, Krzysztof Niemiec wrote:
> The DRM buddy allocator has been moved one level up, and is now renamed
> to just the GPU buddy allocator. This means that the .ko object used to
> run the KUnit test has been renamed, so IGT tries to run a test that
> doesn't exist anymore.
>
> Rename the drm_buddy.c file to gpu_buddy.c to reflect the kernel change,
> and update the igt_kunit() call to invoke the proper tests. Also update
> tests/meson.build to prevent the build system from trying to build
> drm_buddy, and make it build gpu_buddy in its stead.
>
> Signed-off-by: Krzysztof Niemiec <krzysztof.niemiec@intel.com>
> ---
>  tests/{drm_buddy.c => gpu_buddy.c} | 4 ++--
>  tests/meson.build                  | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>  rename tests/{drm_buddy.c => gpu_buddy.c} (51%)
>
> diff --git a/tests/drm_buddy.c b/tests/gpu_buddy.c
> similarity index 51%
> rename from tests/drm_buddy.c
> rename to tests/gpu_buddy.c
> index dbc7c957d..8683b5af0 100644
> --- a/tests/drm_buddy.c
> +++ b/tests/gpu_buddy.c
> @@ -6,9 +6,9 @@
>  #include "igt.h"
>  #include "igt_kmod.h"
>  
> -IGT_TEST_DESCRIPTION("Basic sanity check of DRM's buddy allocator (struct drm_buddy)");
> +IGT_TEST_DESCRIPTION("Basic sanity check of the GPU buddy allocator (struct gpu_buddy)");
>  
>  int igt_main()
>  {
> -	igt_kunit("drm_buddy_test", NULL, NULL);
> +	igt_kunit("gpu_buddy_tests", NULL, NULL);
For some reason, I checked it, and igt_kunit uses strstr() to match _test,
so the _tests might be ok. Still, I would prefer the singular form.

But if it works, I'm fine with this.
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>

-- 
Best regards,
Sebastian