From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_vblank: no need to clear black with black
Date: Mon, 27 Feb 2023 13:39:18 +0200 [thread overview]
Message-ID: <Y/yWZsRqr/VciGCu@intel.com> (raw)
In-Reply-To: <20230227113227.19671-2-juhapekka.heikkila@gmail.com>
On Mon, Feb 27, 2023 at 01:32:27PM +0200, Juha-Pekka Heikkila wrote:
> created framebuffer was uselessly painted black which just wasted
> time from ci.
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
For the series:
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/kms_vblank.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> index 5bd3fefe1..b6c1c7c42 100644
> --- a/tests/kms_vblank.c
> +++ b/tests/kms_vblank.c
> @@ -79,11 +79,10 @@ static void prepare_crtc(data_t *data, int fd, igt_output_t *output)
>
> /* create and set the primary plane fb */
> mode = igt_output_get_mode(output);
> - igt_create_color_fb(fd, mode->hdisplay, mode->vdisplay,
> - DRM_FORMAT_XRGB8888,
> - DRM_FORMAT_MOD_LINEAR,
> - 0.0, 0.0, 0.0,
> - &data->primary_fb);
> + igt_create_fb(fd, mode->hdisplay, mode->vdisplay,
> + DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR,
> + &data->primary_fb);
>
> primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> igt_plane_set_fb(primary, &data->primary_fb);
> --
> 2.39.0
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2023-02-27 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 11:32 [igt-dev] [PATCH i-g-t 1/2] tests/kms_flip_event_leak: no need to clear black with black Juha-Pekka Heikkila
2023-02-27 11:32 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_vblank: " Juha-Pekka Heikkila
2023-02-27 11:39 ` Ville Syrjälä [this message]
2023-02-27 13:27 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_flip_event_leak: " Patchwork
2023-02-27 16:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/yWZsRqr/VciGCu@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox