From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E55D10E1CC for ; Fri, 28 Oct 2022 14:03:46 +0000 (UTC) Date: Fri, 28 Oct 2022 15:59:06 +0200 From: Kamil Konieczny To: igt-dev@lists.freedesktop.org Message-ID: References: <20221010145708.1986912-1-petri.latvala@intel.com> <20221010145708.1986912-7-petri.latvala@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221010145708.1986912-7-petri.latvala@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t 7/7] runner: Disable socket communications for now List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petri Latvala Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Hi Petri, On 2022-10-10 at 17:57:08 +0300, Petri Latvala wrote: > Currently, having i915 CI systems test the socket communications when > testing is impossible. If a test hangs completely, the incomplete set > of results are processed into results.json with an older IGT version > from a previous post-merge build, which is unable to parse socket > communications. Disable them for now. > > This commit will get reverted after suitable testing has been possible > to execute. imho this is a little unclear why adding var is acutally disabling anything, but maybe it is that current CI do not have it ? > > Signed-off-by: Petri Latvala > --- > runner/executor.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/runner/executor.c b/runner/executor.c > index 125f08a2..f6f27d48 100644 > --- a/runner/executor.c > +++ b/runner/executor.c > @@ -1657,7 +1657,8 @@ static int execute_next_entry(struct execute_state *state, > > sigprocmask(SIG_UNBLOCK, sigmask, NULL); > > - if (socketfd >= 0 && !getenv("IGT_RUNNER_DISABLE_SOCKET_COMMUNICATION")) { > + if (socketfd >= 0 && !getenv("IGT_RUNNER_DISABLE_SOCKET_COMMUNICATION") && > + getenv("IGT_RUNNER_ENABLE_SOCKET_COMMUNICATION")) { what about IGT_RUNNER_ENABLE_SOCKET_COMMUNICATION_REMOVE_ME ? or IGT_RUNNER_ENABLE_SOCKET_COMMUNICATION_REMOVE_FIXME ? Or maybe you plan to keep it here and remove _DISABLE_ one ? With or without it Acked-by: Kamil Konieczny -- Kamil > snprintf(envstring, sizeof(envstring), "%d", socketfd); > setenv("IGT_RUNNER_SOCKET_FD", envstring, 1); > } > -- > 2.30.2 >