From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id DC4C610E5D1 for ; Thu, 3 Nov 2022 09:31:18 +0000 (UTC) Date: Thu, 3 Nov 2022 11:30:54 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Nidhi Gupta Message-ID: References: <1667445898-20552-1-git-send-email-nidhi1.gupta@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1667445898-20552-1-git-send-email-nidhi1.gupta@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for legacy platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Thu, Nov 03, 2022 at 08:54:58AM +0530, Nidhi Gupta wrote: > -Cleanup up the display state before starting the subtest. > -Execute the tests only for 5 modes. > -Use primary plane to set the framebuffer. Again multiple patches in the guise of a single patch, with no justification for any of them. NAK. I think we just need to put in the revert and start from scratch. > > Signed-off-by: Bhanuprakash Modem > Signed-off-by: Nidhi Gupta > --- > tests/kms_invalid_mode.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c > index f1c3866..492c92c 100644 > --- a/tests/kms_invalid_mode.c > +++ b/tests/kms_invalid_mode.c > @@ -184,6 +184,7 @@ test_output(data_t *data) > struct igt_fb fb; > int ret; > drmModeModeInfo *mode; > + igt_plane_t *primary; > > igt_display_reset(&data->display); > igt_output_set_pipe(output, data->pipe); > @@ -192,7 +193,14 @@ test_output(data_t *data) > DRM_FORMAT_MOD_LINEAR, > &fb); > > + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); > + igt_plane_set_fb(primary, &fb); > + > for_each_connector_mode(output) { > + igt_output_override_mode(output, NULL); > + igt_display_commit(&data->display); > + if (j__ > 5) > + break; > mode = &output->config.connector->modes[j__]; > igt_require(data->adjust_mode(data, mode)); > igt_output_override_mode(output, mode); > @@ -200,9 +208,11 @@ test_output(data_t *data) > igt_assert(ret == -EINVAL); > } > > + /* Cleanup */ > igt_remove_fb(data->drm_fd, &fb); > + igt_plane_set_fb(primary, NULL); > igt_output_override_mode(output, NULL); > - /*unset_all_crtcs*/ > + igt_output_set_pipe(output, PIPE_NONE); > igt_display_commit(&data->display); > } > > -- > 1.9.1 -- Ville Syrjälä Intel