From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE9D610E5CB for ; Thu, 3 Nov 2022 10:20:33 +0000 (UTC) Date: Thu, 3 Nov 2022 12:20:30 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Gupta, Nidhi1" Message-ID: References: <1667445898-20552-1-git-send-email-nidhi1.gupta@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for legacy platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "igt-dev@lists.freedesktop.org" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Thu, Nov 03, 2022 at 10:16:31AM +0000, Gupta, Nidhi1 wrote: > Hi Ville, > > Only this part "igt_display_try_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); "is creating problem, earlier it was drmModesetcrtc, should I set it back to drmModesetcrtc? There is a lot more wrong than that. > > -----Original Message----- > From: Ville Syrjälä > Sent: Thursday, November 3, 2022 3:21 PM > To: Gupta, Nidhi1 > Cc: igt-dev@lists.freedesktop.org > Subject: Re: [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for legacy platform > > On Thu, Nov 03, 2022 at 09:46:57AM +0000, Gupta, Nidhi1 wrote: > > Hi Ville, > > > > It's a small patch, just cleaning up the display state before executing the subtest. > > No, it's three patches, none of which fix the already broken test. > > > > > Nidhi > > > > -----Original Message----- > > From: Ville Syrjälä > > Sent: Thursday, November 3, 2022 3:01 PM > > To: Gupta, Nidhi1 > > Cc: igt-dev@lists.freedesktop.org > > Subject: Re: [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for > > legacy platform > > > > On Thu, Nov 03, 2022 at 08:54:58AM +0530, Nidhi Gupta wrote: > > > -Cleanup up the display state before starting the subtest. > > > -Execute the tests only for 5 modes. > > > -Use primary plane to set the framebuffer. > > > > Again multiple patches in the guise of a single patch, with no justification for any of them. NAK. > > > > I think we just need to put in the revert and start from scratch. > > > > > > > > Signed-off-by: Bhanuprakash Modem > > > Signed-off-by: Nidhi Gupta > > > --- > > > tests/kms_invalid_mode.c | 12 +++++++++++- > > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > > > diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c > > > index f1c3866..492c92c 100644 > > > --- a/tests/kms_invalid_mode.c > > > +++ b/tests/kms_invalid_mode.c > > > @@ -184,6 +184,7 @@ test_output(data_t *data) > > > struct igt_fb fb; > > > int ret; > > > drmModeModeInfo *mode; > > > + igt_plane_t *primary; > > > > > > igt_display_reset(&data->display); > > > igt_output_set_pipe(output, data->pipe); @@ -192,7 +193,14 @@ > > > test_output(data_t *data) > > > DRM_FORMAT_MOD_LINEAR, > > > &fb); > > > > > > + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); > > > + igt_plane_set_fb(primary, &fb); > > > + > > > for_each_connector_mode(output) { > > > + igt_output_override_mode(output, NULL); > > > + igt_display_commit(&data->display); > > > + if (j__ > 5) > > > + break; > > > mode = &output->config.connector->modes[j__]; > > > igt_require(data->adjust_mode(data, mode)); > > > igt_output_override_mode(output, mode); @@ -200,9 +208,11 @@ > > > test_output(data_t *data) > > > igt_assert(ret == -EINVAL); > > > } > > > > > > + /* Cleanup */ > > > igt_remove_fb(data->drm_fd, &fb); > > > + igt_plane_set_fb(primary, NULL); > > > igt_output_override_mode(output, NULL); > > > - /*unset_all_crtcs*/ > > > + igt_output_set_pipe(output, PIPE_NONE); > > > igt_display_commit(&data->display); > > > } > > > > > > -- > > > 1.9.1 > > > > -- > > Ville Syrjälä > > Intel > > -- > Ville Syrjälä > Intel -- Ville Syrjälä Intel