From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 5/6] lib/runnercomms: Report empty comms dump as empty
Date: Mon, 7 Nov 2022 14:59:55 +0100 [thread overview]
Message-ID: <Y2kPW0La0l2AP6NG@kamilkon-desk1> (raw)
In-Reply-To: <20221107120151.2365523-5-petri.latvala@intel.com>
On 2022-11-07 at 14:01:50 +0200, Petri Latvala wrote:
> A mistake that went unnoticed because it's only hit if igt_runner is
> killed immediately after initializing the execution but before
> executing the test binary.
>
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arek@hiler.eu>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> lib/runnercomms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/runnercomms.c b/lib/runnercomms.c
> index 344312bd..034ba0a2 100644
> --- a/lib/runnercomms.c
> +++ b/lib/runnercomms.c
> @@ -515,7 +515,7 @@ int comms_read_dump(int fd, struct comms_visitor *visitor)
> return COMMSPARSE_ERROR;
>
> if (statbuf.st_size == 0)
> - return COMMSPARSE_ERROR;
> + return COMMSPARSE_EMPTY;
>
> buf = mmap(NULL, statbuf.st_size, PROT_READ, MAP_SHARED, fd, 0);
> if (buf == MAP_FAILED)
> --
> 2.30.2
>
next prev parent reply other threads:[~2022-11-07 14:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 12:01 [igt-dev] [PATCH i-g-t 1/6] runner: Use a bigger buffer for receiving test outputs Petri Latvala
2022-11-07 12:01 ` [igt-dev] [PATCH i-g-t 2/6] igt_core: Split too long log lines when sending to runner with comms Petri Latvala
2022-11-07 14:16 ` Kamil Konieczny
2022-11-07 15:14 ` Petri Latvala
2022-11-07 16:40 ` Kamil Konieczny
2022-11-07 16:45 ` Petri Latvala
2022-11-07 12:01 ` [igt-dev] [PATCH i-g-t 3/6] runner: Continue using socket comms when getting an invalid packet Petri Latvala
2022-11-07 16:16 ` Kamil Konieczny
2022-11-07 12:01 ` [igt-dev] [PATCH i-g-t 4/6] igt_core: Make sure test result gets to runner when test has no subtests Petri Latvala
2022-11-07 13:57 ` Kamil Konieczny
2022-11-07 12:01 ` [igt-dev] [PATCH i-g-t 5/6] lib/runnercomms: Report empty comms dump as empty Petri Latvala
2022-11-07 13:59 ` Kamil Konieczny [this message]
2022-11-07 12:01 ` [igt-dev] [PATCH i-g-t 6/6] Revert "runner: Disable socket communications for now" Petri Latvala
2022-11-07 14:00 ` Kamil Konieczny
2022-11-07 13:40 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/6] runner: Use a bigger buffer for receiving test outputs Patchwork
2022-11-07 16:45 ` [igt-dev] [PATCH i-g-t 1/6] " Kamil Konieczny
2022-11-08 9:39 ` Petri Latvala
-- strict thread matches above, loose matches on Subject: below --
2022-11-08 10:07 [igt-dev] [PATCH i-g-t v2 " Petri Latvala
2022-11-08 10:07 ` [igt-dev] [PATCH i-g-t 5/6] lib/runnercomms: Report empty comms dump as empty Petri Latvala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2kPW0La0l2AP6NG@kamilkon-desk1 \
--to=kamil.konieczny@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox