From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 18D2810E0A1
 for <igt-dev@lists.freedesktop.org>; Mon, 14 Nov 2022 14:03:57 +0000 (UTC)
Date: Mon, 14 Nov 2022 15:03:22 +0100
From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Message-ID: <Y3JKqlSxLdgqcPFc@kamilkon-desk1>
References: <20221111080529.2427645-1-petri.latvala@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20221111080529.2427645-1-petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] runner: Fix a memory leak in
 stderr_contains_warnings
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Cc: Petri Latvala <petri.latvala@intel.com>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

Hi,

On 2022-11-11 at 10:05:29 +0200, Petri Latvala wrote:
> The matches object's internals weren't released.
> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arek@hiler.eu>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
>  runner/resultgen.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/runner/resultgen.c b/runner/resultgen.c
> index 3d753828..21a3ed84 100644
> --- a/runner/resultgen.c
> +++ b/runner/resultgen.c
> @@ -1912,6 +1912,8 @@ static bool stderr_contains_warnings(const char *beg, const char *end)
>  		i++;
>  	}
>  
> +	free_matches(&matches);
> +
>  	return false;

On second look you need to free it also before return true ?
So maybe reformat it, use break and then 'return found;' ?

Regards,
Kamil

>  }
>  
> -- 
> 2.30.2
>