Re: [igt-dev] [PATCH i-g-t] runner: Fix a memory leak in stderr_contains_warnings

[Petri Latvala <petri.latvala@intel.com>]

On Mon, Nov 14, 2022 at 03:03:22PM +0100, Kamil Konieczny wrote:
> Hi,
> 
> On 2022-11-11 at 10:05:29 +0200, Petri Latvala wrote:
> > The matches object's internals weren't released.
> > 
> > Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> > Cc: Arkadiusz Hiler <arek@hiler.eu>
> > Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> > ---
> >  runner/resultgen.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/runner/resultgen.c b/runner/resultgen.c
> > index 3d753828..21a3ed84 100644
> > --- a/runner/resultgen.c
> > +++ b/runner/resultgen.c
> > @@ -1912,6 +1912,8 @@ static bool stderr_contains_warnings(const char *beg, const char *end)
> >  		i++;
> >  	}
> >  
> > +	free_matches(&matches);
> > +
> >  	return false;
> 
> On second look you need to free it also before return true ?
> So maybe reformat it, use break and then 'return found;' ?

Ah, well caught! v2 inc.


-- 
Petri Latvala