public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: CQ Tang <cq.tang@intel.com>,
	Arjun Melkaveri <arjun.melkaveri@intel.com>,
	Ursulin Tvrtko <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 1/1] tests/gem_lmem_swapping: retry execbuf on no memory error with oom testing
Date: Thu, 17 Nov 2022 19:29:05 +0100	[thread overview]
Message-ID: <Y3Z9cR7m72AoRF4K@kamilkon-desk1> (raw)
In-Reply-To: <20221114164559.30419-2-zbigniew.kempczynski@intel.com>

On 2022-11-14 at 17:45:59 +0100, Zbigniew Kempczyński wrote:
> From: CQ Tang <cq.tang@intel.com>
> 
> When doing oom test, we have side processes to eat all the system memory,
> so the swapping test process might encounter -ENOMEM or -ENXIO error as
> well, we need to retry the operation when these errors are returned.
> 
> Signed-off-by: CQ Tang <cq.tang@intel.com>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Cc: Arjun Melkaveri <arjun.melkaveri@intel.com>
> Cc: Ursulin Tvrtko <tvrtko.ursulin@intel.com>

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

> ---
>  tests/i915/gem_lmem_swapping.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_lmem_swapping.c b/tests/i915/gem_lmem_swapping.c
> index cccdb3195b..969fb9080b 100644
> --- a/tests/i915/gem_lmem_swapping.c
> +++ b/tests/i915/gem_lmem_swapping.c
> @@ -133,7 +133,7 @@ static uint32_t create_bo(int i915,
>  
>  retry:
>  	ret = __gem_create_in_memory_region_list(i915, &handle, size, 0, region, 1);
> -	if (do_oom_test && ret == -ENOMEM)
> +	if (do_oom_test && (ret == -ENOMEM || ret == -ENXIO))
>  		goto retry;
>  	igt_assert_eq(ret, 0);
>  	return handle;
> -- 
> 2.34.1
> 

  reply	other threads:[~2022-11-17 18:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14 16:45 [igt-dev] [PATCH i-g-t 0/1] Add missing ENXIO check Zbigniew Kempczyński
2022-11-14 16:45 ` [igt-dev] [PATCH i-g-t 1/1] tests/gem_lmem_swapping: retry execbuf on no memory error with oom testing Zbigniew Kempczyński
2022-11-17 18:29   ` Kamil Konieczny [this message]
2022-11-14 18:47 ` [igt-dev] ✓ Fi.CI.BAT: success for Add missing ENXIO check Patchwork
2022-11-14 21:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-11-16 19:15   ` Zbigniew Kempczyński
2022-11-17  2:12     ` Vudum, Lakshminarayana
2022-11-16 23:08 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3Z9cR7m72AoRF4K@kamilkon-desk1 \
    --to=kamil.konieczny@linux.intel.com \
    --cc=arjun.melkaveri@intel.com \
    --cc=cq.tang@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tvrtko.ursulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox