Re: [igt-dev] [PATCH i-g-t v2] tests/i915/gem_ctx_isolation.c : Increase MAX_REG

[Kamil Konieczny <kamil.konieczny@linux.intel.com>]

Hi,

On 2022-12-01 at 11:02:26 +0530, Vikas Srivastava wrote:
> From: Steve Hampson <steven.t.hampson@intel.com>
> 
> Increase MAX_REG from 0x200000 to 0x400000 to support new large MMIO
> base addresses such as to support GEN12+ platform base addresses.

While it is ok for gen12+ this imho should be platform dependent
as now we will allow bigger regs for older platforms. It may be
something worth to fix in future, as of now

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Small nit - do not put space "tests/i915/gem_ctx_isolation.c :"
and also cut off ".c", so it will look like:
tests/i915/gem_ctx_isolation: Increase MAX_REG

btw no need to resend this,

Regards,
Kamil

> 
> Signed-off-by: Steve Hampson <steven.t.hampson@intel.com>
> Acked-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> ---
>  tests/i915/gem_ctx_isolation.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_ctx_isolation.c b/tests/i915/gem_ctx_isolation.c
> index dc52a9a03..ec6935714 100644
> --- a/tests/i915/gem_ctx_isolation.c
> +++ b/tests/i915/gem_ctx_isolation.c
> @@ -27,7 +27,8 @@
>  #include "igt_dummyload.h"
>  #include "igt_types.h"
>  
> -#define MAX_REG 0x200000
> +/* MAX_REG must be greater than the maximum register address. */
> +#define MAX_REG 0x400000
>  #define NUM_REGS (MAX_REG / sizeof(uint32_t))
>  
>  #define PAGE_ALIGN(x) ALIGN(x, 4096)
> -- 
> 2.25.1
>