From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tools/intel_vbt_decode: decode VBT MIPI sequence v4 native flag
Date: Tue, 29 Nov 2022 11:59:52 +0200 [thread overview]
Message-ID: <Y4XYGG+X8qFZiIsf@intel.com> (raw)
In-Reply-To: <20221129084710.1151876-1-jani.nikula@intel.com>
On Tue, Nov 29, 2022 at 10:47:10AM +0200, Jani Nikula wrote:
> MIPI sequence v4 has a flag for native/non-native GPIO.
An naturally zero docs on what it actually means. But looks like
we're just meant to poke various DE registers for the "native" case.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> tools/intel_vbt_decode.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
> index a63bfdda142a..94a910b5c107 100644
> --- a/tools/intel_vbt_decode.c
> +++ b/tools/intel_vbt_decode.c
> @@ -2049,8 +2049,12 @@ static const uint8_t *mipi_dump_gpio(const uint8_t *data, uint8_t seq_version)
> number = *data++;
> flags = *data++;
>
> - printf("\t\t\tGPIO index %u, number %u, set %d (0x%02x)\n",
> - index, number, flags & 1, flags);
> + if (seq_version >= 4)
> + printf("\t\t\tGPIO index %u, number %u, native %d, set %d (0x%02x)\n",
> + index, number, !(flags & 2), flags & 1, flags);
> + else
> + printf("\t\t\tGPIO index %u, number %u, set %d (0x%02x)\n",
> + index, number, flags & 1, flags);
> } else {
> index = *data++;
> flags = *data++;
> --
> 2.34.1
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2022-11-29 9:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 8:47 [igt-dev] [PATCH i-g-t] tools/intel_vbt_decode: decode VBT MIPI sequence v4 native flag Jani Nikula
2022-11-29 9:59 ` Ville Syrjälä [this message]
2022-11-29 10:02 ` Jani Nikula
2022-11-29 10:49 ` Ville Syrjälä
2022-11-29 13:14 ` Jani Nikula
2022-11-29 10:06 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-11-29 12:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4XYGG+X8qFZiIsf@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox