From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id E490B10E8F1 for ; Thu, 26 Jan 2023 13:45:40 +0000 (UTC) Date: Thu, 26 Jan 2023 15:42:36 +0200 From: Petri Latvala To: Kamil Konieczny , igt-dev@lists.freedesktop.org, Arkadiusz Hiler Message-ID: References: <20230126105338.419418-1-petri.latvala@intel.com> <20230126131228.o36lg6hglii25d64@kamilkon-desk1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230126131228.o36lg6hglii25d64@kamilkon-desk1> Subject: Re: [igt-dev] [PATCH i-g-t 0/3] runner: Using 'abort' as test result instead of a separate test List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Thu, Jan 26, 2023 at 02:12:28PM +0100, Kamil Konieczny wrote: > Hi Petri, > > On 2023-01-26 at 12:53:35 +0200, Petri Latvala wrote: > > If a test caused an abort condition to trigger, a pseudoresult > > "igt@runner@aborted" would be generated, detailing which test caused > > the condition. That was implemented in a simpler world where there > > were no dynamic subtests and CI systems (i915-CI in particular) didn't > > have much test resuming happening. > > > > The generated pseudoresult was completely unable to point to a > > particular dynamic subtest if the executed subtest had any, and there > > could inherently be only one of them. When combined with the fact that > > the pseudoresult doesn't have logs that could be used to automatically > > point to particular bug reports, that made results filtering by > > CIBugLog difficult. > > > > With socket communications it's easier to inject information "in > > between" test's logs and result overriding is designed into the > > system. Thus, when using socket communications, this patch series will > > make the abort-condition-causing test's result 'abort' instead of > > using that pseudoresult. > > > > The flow becomes a little bit messier with monitor_output() gaining > > more and more out-parameters but those can be cleaned later. > > Please copy this into description of your last patch 3/3 > runner: Use 'abort' as result if a test caused an abort > > I would prefer to have all info about why patch is needed > in git log rather than patchwork. > > For the series > Acked-by: Kamil Konieczny I'll make that change, thanks. -- Petri Latvala