From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Martin Peres <martin.peres@mupuf.org>
Cc: Petri Latvala <petri.latvala@intel.com>,
nouveau@lists.freedesktop.org, igt-dev@lists.freedesktop.org,
Martin Peres <martin.peres@free.fr>,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Test 32x32 cursors
Date: Thu, 18 Mar 2021 14:39:19 +0200 [thread overview]
Message-ID: <YFNJ96fvZpNKtRGv@intel.com> (raw)
In-Reply-To: <4793631d-ee46-3d80-aa24-30d18d42e38b@mupuf.org>
On Thu, Mar 18, 2021 at 08:39:01AM +0200, Martin Peres wrote:
> On 18/03/2021 00:45, Lyude wrote:
> > From: Lyude Paul <lyude@redhat.com>
> >
> > Since pre-nve4 only has two cursor sizes (32x32 and 64x64), we should at
> > least test both of them.
>
> This adds 36 subtests, which take about 1s in average. So the runtime is
> not significantly increased on the Intel side.
>
> It also seems that Intel should add skips or fix the kernel to support
> these 32xXX format.
Intel hw at least does not support 32x32 cursors. We should
probably just just probe the kernel to see if it accepts the
requested cursor size, and skip the subtest if not. That
would also let us remove the i915 platform specific information
from has_nonsquare_cursors().
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-03-18 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 22:45 [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Test 32x32 cursors Lyude
2021-03-18 1:07 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-03-18 4:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-03-18 6:39 ` [igt-dev] [PATCH i-g-t] " Martin Peres
2021-03-18 9:27 ` Petri Latvala
2021-03-18 12:39 ` Ville Syrjälä [this message]
2021-03-18 18:06 ` Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFNJ96fvZpNKtRGv@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=bskeggs@redhat.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=martin.peres@free.fr \
--cc=martin.peres@mupuf.org \
--cc=nouveau@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox