From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Lyude <lyude@redhat.com>
Cc: igt-dev@lists.freedesktop.org, nouveau@lists.freedesktop.org,
Martin Peres <martin.peres@free.fr>,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [igt-dev] [PATCH i-g-t v3] tests/kms_cursor_crc: Probe kernel for cursor size support
Date: Wed, 24 Mar 2021 18:12:48 +0200 [thread overview]
Message-ID: <YFtlAL+YxOc/dN4H@intel.com> (raw)
In-Reply-To: <20210323172513.1519481-1-lyude@redhat.com>
On Tue, Mar 23, 2021 at 01:25:13PM -0400, Lyude wrote:
> From: Lyude Paul <lyude@redhat.com>
>
> Currently we just assume that every cursor size up to data->cursor_max_w/h will
> be supported by the driver, and check for support of nonsquare cursors by
> checking if we're running on u815 and if so, which variant of intel hardware
> we're running on. This isn't really ideal as we're about to enable 32x32 cursor
> size tests for nouveau, and Intel hardware doesn't support cursor sizes that
> small.
>
> So, fix this by removing has_nonsquare_cursors() and replacing it with a more
> generic require_cursor_size() function which checks whether or not the driver
> we're using supports a given cursor size by attempting a test-only atomic
> commit.
>
> v3:
> * Also probe for cursor support on systems without atomic support
Gave this a go on my i865, and after removing a bogus max_w==max_h
assert it all passed, and your non-square probing worked fine.
I'll need to send a patch to nuke that bogus assert, and I also had
an idea to test the max sized cursor as well (in case it's not square
and thus not being tested already)...
with the s/u815/i915/ Petri pointed out
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-03-24 16:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 22:21 [igt-dev] [PATCH i-g-t v2 0/2] tests/kms_cursor_crc: Test 32x32 cursors Lyude
2021-03-18 22:21 ` [igt-dev] [PATCH i-g-t v2 1/2] tests/kms_cursor_crc: Probe kernel for cursor size support Lyude
2021-03-19 7:20 ` Martin Peres
2021-03-19 15:01 ` Ville Syrjälä
2021-03-19 17:40 ` Lyude Paul
2021-03-19 18:00 ` Ville Syrjälä
2021-03-19 18:43 ` Lyude Paul
2021-03-19 21:21 ` Ville Syrjälä
2021-03-21 12:59 ` Daniel Vetter
2021-03-23 17:25 ` [igt-dev] [PATCH i-g-t v3] " Lyude
2021-03-24 8:59 ` Petri Latvala
2021-03-24 16:12 ` Ville Syrjälä [this message]
2021-03-18 22:21 ` [igt-dev] [PATCH i-g-t v2 2/2] tests/kms_cursor_crc: Test 32x32 cursors Lyude
2021-03-18 22:58 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-03-19 3:52 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-03-23 18:46 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_crc: Test 32x32 cursors (rev2) Patchwork
2021-03-24 11:15 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFtlAL+YxOc/dN4H@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=bskeggs@redhat.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=lyude@redhat.com \
--cc=martin.peres@free.fr \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox