Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Alan Previn <alan.previn.teres.alexis@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v2 05/15] Add MI_SET_APPID instruction definition
Date: Wed, 21 Apr 2021 08:30:34 -0400	[thread overview]
Message-ID: <YIAa6grJ8Me3UD9B@intel.com> (raw)
In-Reply-To: <20210325054549.465386-6-alan.previn.teres.alexis@intel.com>

On Wed, Mar 24, 2021 at 10:45:39PM -0700, Alan Previn wrote:
> Add MI_SET_APPID instruction and param definitions
> 
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> ---
>  lib/intel_reg.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/lib/intel_reg.h b/lib/intel_reg.h
> index ac1fc6cb..553f4839 100644
> --- a/lib/intel_reg.h
> +++ b/lib/intel_reg.h
> @@ -2546,6 +2546,15 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
>  #define CTXT_PALETTE_SAVE_DISABLE	(1<<3)
>  #define CTXT_PALETTE_RESTORE_DISABLE	(1<<2)
>  
> +#define MI_SET_APPID                    (0x0e<<23)

The trend is to add the new ones with space (0x0E << 23)

> +#define APPID_CTXSAVE_INHIBIT           (1<<8)
> +#define APPID_CTXREST_INHIBIT           (1<<9)
> +#define DISPLAY_APPTYPE                 (0)
> +#define TRANSCODE_APPTYPE               (1)
> +#define APPTYPE(n)                      ((n & 0x1)<<7)

please remove the useless & 0x1

with that

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>



> +#define APPID(n)                        (n & 0x7f)
> +
> +
>  /* Dword 0 */
>  #define MI_VERTEX_BUFFER		(0x17<<23)
>  #define MI_VERTEX_BUFFER_IDX(x)		(x<<20)
> -- 
> 2.25.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2021-04-21 12:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25  5:45 [igt-dev] [PATCH i-g-t v2 00/15] Introduce PXP Test Alan Previn
2021-03-25  5:45 ` [igt-dev] [PATCH i-g-t v2 01/15] Sync i915_drm.h UAPI for PXP Alan Previn
2021-04-21 10:10   ` Rodrigo Vivi
2021-04-21 10:33   ` Petri Latvala
2021-04-21 20:53     ` Teres Alexis, Alan Previn
2021-03-25  5:45 ` [igt-dev] [PATCH i-g-t v2 02/15] Add basic PXP testing of buffer and context alloc Alan Previn
2021-04-21 10:09   ` Rodrigo Vivi
2021-05-13 19:23     ` Teres Alexis, Alan Previn
2021-03-25  5:45 ` [igt-dev] [PATCH i-g-t v2 03/15] Perform a regular 3d copy as a control checkpoint Alan Previn
2021-04-21 10:28   ` Rodrigo Vivi
2021-04-21 20:57     ` Teres Alexis, Alan Previn
2021-03-25  5:45 ` [igt-dev] [PATCH i-g-t v2 04/15] Add PXP attribute support in batchbuffer and buffer_ops libs Alan Previn
2021-03-25  5:45 ` [igt-dev] [PATCH i-g-t v2 05/15] Add MI_SET_APPID instruction definition Alan Previn
2021-04-21 12:30   ` Rodrigo Vivi [this message]
2021-04-21 20:58     ` Teres Alexis, Alan Previn
2021-03-25  5:45 ` [igt-dev] [PATCH i-g-t v2 06/15] Enable protected session cmd in gen12_render_copyfunc Alan Previn
2021-03-25  5:45 ` [igt-dev] [PATCH i-g-t v2 07/15] Add subtest to copy raw source to protected dest Alan Previn
2021-03-25  5:45 ` [igt-dev] [PATCH i-g-t v2 08/15] Add test where both src and dest are protected Alan Previn
2021-03-25  5:45 ` [igt-dev] [PATCH i-g-t v2 09/15] Verify PXP teardown occured through suspend-resume Alan Previn
2021-03-25  5:45 ` [igt-dev] [PATCH i-g-t v2 10/15] Verify execbuf fails with stale PXP context after teardown Alan Previn
2021-03-25  5:45 ` [igt-dev] [PATCH i-g-t v2 11/15] Verify execbuf fails with stale PXP buffer " Alan Previn
2021-03-25  5:45 ` [igt-dev] [PATCH i-g-t v2 12/15] Verify execbuf ok with stale prot-buff and regular context Alan Previn
2021-03-25  5:45 ` [igt-dev] [PATCH i-g-t v2 13/15] Ensure RESET_STAT reports invalidated protected context Alan Previn
2021-03-25  5:45 ` [igt-dev] [PATCH i-g-t v2 14/15] Verify protected surfaces are dma buffer sharable Alan Previn
2021-03-25  5:45 ` [igt-dev] [PATCH i-g-t v2 15/15] tests/i915_pxp: CRC validation for display tests Alan Previn
2021-03-25 13:47 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce PXP Test (rev2) Patchwork
2021-03-25 16:46 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIAa6grJ8Me3UD9B@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=alan.previn.teres.alexis@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox