From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v3,1/3] lib/kms: Commit primary plane props with COMMIT_LEGACY
Date: Thu, 22 Apr 2021 12:01:42 +0200 [thread overview]
Message-ID: <YIFJhoTaYfbRVafu@phenom.ffwll.local> (raw)
In-Reply-To: <YIBcroO7VtZB7rfL@intel.com>
On Wed, Apr 21, 2021 at 08:11:10PM +0300, Ville Syrjälä wrote:
> On Wed, Apr 21, 2021 at 03:42:56AM -0000, Patchwork wrote:
> > == Series Details ==
> >
> > Series: series starting with [i-g-t,v3,1/3] lib/kms: Commit primary plane props with COMMIT_LEGACY
> > URL : https://patchwork.freedesktop.org/series/89278/
> > State : success
>
> So apparently avoiding those two redundant color encoding/range
> setprop ioctls when chaging the fb does avoid the test failure
> on glk. How on earth two setprop ioctl can do this is a mystery
> The setprops should essentially be nops, and should just result
> in reprogramming the plane registers a few times using an
> identical state.
Might we need a full modeset for the hw to pick them up perhaps? Or at
least plane enable/disable cycle. Doesn't make sense, but hey hw, maybe it
only picks these up on initial enable.
Only other thing I can think of is to maybe double check the state
readout to make sure we really program this correctly in both cases.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-04-22 10:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 22:17 [igt-dev] [PATCH i-g-t v3 1/3] lib/kms: Commit primary plane props with COMMIT_LEGACY Ville Syrjala
2021-04-20 22:17 ` [igt-dev] [PATCH i-g-t v3 2/3] lib/kms: Reset color encoding to BT.709 Ville Syrjala
2021-04-20 22:17 ` [igt-dev] [PATCH i-g-t v3 3/3] lib/kms: Optimize out redundant plane color encoding/range prop changes Ville Syrjala
2021-04-21 0:40 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/3] lib/kms: Commit primary plane props with COMMIT_LEGACY Patchwork
2021-04-21 3:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-04-21 17:11 ` Ville Syrjälä
2021-04-22 10:01 ` Daniel Vetter [this message]
2021-04-22 13:25 ` Ville Syrjälä
2021-04-22 18:00 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIFJhoTaYfbRVafu@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=igt-dev@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox