Re: [igt-dev] [PATCH i-g-t 1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, Aug 19, 2021 at 01:59:40PM +0200, Thomas Hellström wrote:
> From: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
> 
> Add a method to query if the device supports setting and getting legacy
> tiling formats for buffer objects.
> 
> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
> ---
>  lib/ioctl_wrappers.c | 17 +++++++++++++++++
>  lib/ioctl_wrappers.h |  1 +
>  2 files changed, 18 insertions(+)
> 
> diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
> index 09eb3ce7..3f412f7a 100644
> --- a/lib/ioctl_wrappers.c
> +++ b/lib/ioctl_wrappers.c
> @@ -136,6 +136,23 @@ __gem_get_tiling(int fd, struct drm_i915_gem_get_tiling *arg)
>  	return err;
>  }
>  
> +/**
> + * gem_has_legacy_hw_tiling:
> + * @fd: open i915 drm file descriptor
> + *
> + * Feature check to query if the device supports setting/getting
> + * legacy tiling formats for buffer objects
> + *
> + * Returns: True if tiling is supported
> + */
> +bool
> +gem_has_legacy_hw_tiling(int fd)
> +{
> +	struct drm_i915_gem_get_tiling arg = {};
> +
> +	return (__gem_get_tiling(fd, &arg) != -EOPNOTSUPP);

Spurious parens.

Looks to match the kernel so
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> +}
> +
>  /**
>   * gem_get_tiling:
>   * @fd: open i915 drm file descriptor
> diff --git a/lib/ioctl_wrappers.h b/lib/ioctl_wrappers.h
> index 9a897fec..d248c568 100644
> --- a/lib/ioctl_wrappers.h
> +++ b/lib/ioctl_wrappers.h
> @@ -118,6 +118,7 @@ void gem_require_caching(int fd);
>  void gem_require_ring(int fd, unsigned ring);
>  bool gem_has_mocs_registers(int fd);
>  void gem_require_mocs_registers(int fd);
> +bool gem_has_legacy_hw_tiling(int fd);
>  
>  #define gem_has_ring(f, r) gem_context_has_engine(f, 0, r)
>  
> -- 
> 2.31.1

-- 
Ville Syrjälä
Intel