From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6074B6EDD8 for ; Wed, 6 Oct 2021 17:25:58 +0000 (UTC) Date: Wed, 6 Oct 2021 13:25:25 -0400 From: Rodrigo Vivi Message-ID: References: <20211006161444.904476-1-rodrigo.vivi@intel.com> <20211006161444.904476-2-rodrigo.vivi@intel.com> <877deqvzre.wl-ashutosh.dixit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877deqvzre.wl-ashutosh.dixit@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t 1/8] tests/i915/gem_pxp: Add LOCAL_ UAPI defines List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Dixit, Ashutosh" Cc: igt-dev@lists.freedesktop.org, Alan Previn , Petri Latvala List-ID: On Wed, Oct 06, 2021 at 10:17:41AM -0700, Dixit, Ashutosh wrote: > On Wed, 06 Oct 2021 09:14:37 -0700, Rodrigo Vivi wrote: > > > > While the UAPI changes don't propagate to drm-next we should > > have that as LOCAL_ ones. > > Please add these in lib/i915/i915_drm_local.h as follows: Could we move this file to the include directory and document it in the README.md along with the uapi sync mention? > > /* > * It is necessary on occasion to add uapi declarations to IGT before they > * appear in imported kernel uapi headers. This header is provided for this > * purpose. > > * Early uapi declarations should be added here exactly as they are > * expected to appear in the kernel uapi headers, i.e. without the LOCAL_ > * or local_ prefix and without any #ifndef's. Attempt should be made to > * clean these up when kernel uapi headers are sync'd. > */ > > > > > That was my mistake during review and merge since I had > > ignored the rules documented at README.md and considered > > drm-intel branches would be enough. I'm sorry. > > > > Cc: Alan Previn > > Cc: Petri Latvala > > Signed-off-by: Rodrigo Vivi