Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_ctx_exec: Added test description for testcase
Date: Wed, 9 Mar 2022 14:28:59 +0100	[thread overview]
Message-ID: <YiirmxorwOEmW/PQ@kamilkon-DESK1> (raw)
In-Reply-To: <20220309094719.144716-2-priyanka.dandamudi@intel.com>

Hi Priyanka,

please do not resend this, I missed two issues. I would be
gratefull if you could reply to first question below.

Dnia 2022-03-09 at 15:17:18 +0530, priyanka.dandamudi@intel.com napisał(a):
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> 
> Added test description to all the available subtests.
> 
> v2: Added description for newly added test case.
> 
> v3: Modified test descriptions.
> 
> Cc: Melkaveri Arjun <arjun.melkaveri@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> ---
<cut>
>  
> +	igt_describe("Verify that contexts are automatically shotdown"
------------------------------------------------------------ ^
Did you mean "shutdown" here ?

> +		     " on close, if hangchecking is disabled.");

>  	igt_subtest("basic-nohangcheck")
>  		nohangcheck_hostile(fd);
>  
> +	igt_describe("Race the execution and interrupt handlers along a context,"
> +	             " while closing it at a random time.");
-- ^^^
I missed it here, there are too many spaces. You can catch it
with checkpatch or use editor to show white chars (tabs, spaces).

>  	igt_subtest_group {
>  		igt_fixture {
>  			intel_allocator_multiprocess_start();
> @@ -505,6 +515,8 @@ igt_main
>  		}
>  	}
>  
> +	igt_describe("Check if the kernel doesn't leak the vma"
> +		     " pin_count for the last context on reset.");
>  	igt_subtest("reset-pin-leak") {
>  		int i;
>  		uint64_t ahnd;
> -- 
> 2.25.1
> 

Regards,
Kamil

  parent reply	other threads:[~2022-03-09 13:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-09  9:47 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_ctx_exec priyanka.dandamudi
2022-03-09  9:47 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_ctx_exec: Added test description for testcase priyanka.dandamudi
2022-03-09 12:54   ` Kamil Konieczny
2022-03-09 13:28   ` Kamil Konieczny [this message]
2022-03-10  4:55     ` Dandamudi, Priyanka
2022-03-09  9:47 ` [igt-dev] [PATCH i-g-t 2/2] HAX: don't do full run priyanka.dandamudi
2022-03-09 15:11 ` [igt-dev] ✗ Fi.CI.BAT: failure for HAX add description to gem_ctx_exec Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YiirmxorwOEmW/PQ@kamilkon-DESK1 \
    --to=kamil.konieczny@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox