Re: [igt-dev] [PATCH i-g-t 1/2] prime_self_import: Add description for test

[Kamil Konieczny <kamil.konieczny@linux.intel.com>]

Hi Priyanka,

Dnia 2022-03-21 at 18:42:04 +0530, priyanka.dandamudi@intel.com napisał(a):
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> 
> Add description for test.
> 
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Arjun Melkaveri <arjun.melkaveri@intel.com>
> ---
>  tests/prime_self_import.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/prime_self_import.c b/tests/prime_self_import.c
> index 38a55439..a56ec313 100644
> --- a/tests/prime_self_import.c
> +++ b/tests/prime_self_import.c
> @@ -442,6 +442,8 @@ igt_main
>  	int i;
>  
>  	for (i = 0; i < ARRAY_SIZE(tests); i++) {
> +		igt_describe_f("Verify PRIME_HANDLE_TO_FD functionality in"
> +				" different scenarios:%s", tests[i].name);

Imho this doesn't add much explanation to test, so either keep
it short, like "Verify prime import/export with %s", or add
description to tests[] and print tests[i].idescription

>  		igt_subtest(tests[i].name)
>  			tests[i].fn();
>  	}
> -- 
> 2.25.1
> 
Regards,
Kamil